Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typeorm: tests are not closing the connection when failing #168

Open
blumamir opened this issue Aug 1, 2021 · 0 comments
Open

typeorm: tests are not closing the connection when failing #168

blumamir opened this issue Aug 1, 2021 · 0 comments
Labels
good first issue Good for newcomers

Comments

@blumamir
Copy link
Contributor

blumamir commented Aug 1, 2021

typeorm tests are creating a new db connection in each test. If something goes wrong (assertion fails, exception thrown), the test does not close this connection which causes the following tests to fail as well.
We need to move the logic into afterEach hook so tests clean the environment after they are done for whatever reason.
@blumamir blumamir added the good first issue Good for newcomers label Aug 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@blumamir