Upstreaming instrumentations

[seemk]

Hey, great work on the instrumentations!

Do you have plans to upstream these to opentelemetry-js-contrib in the nearer future?

[blumamir]

Hi, @seemk
By maintaining these instrumentations in a separate repo we are able to add features and bug fixes super fast, and publish new versions frequently. It also allows us to stay up to date with the latest otel sdk versions.
All the PRs in this repo are unit-tested, reviewed and verified with RC versions on our setup before publishing.
The instrumentations are vendor-neutral, strictly follows the open telemetry semantic conventions, and released with an open-source license.

We welcome any contribution, so if you find an issue or need a feature, feel free to reach out or open a PR and we'll review it

[iNikem]

@blumamir Even if this code lives in opentelemetry-js-contrib repo you may be codeowners for it and thus move with whatever speed you desire. And that certainly will help with discoverability of this instrumentation, don't you think?

[blumamir]

you may be codeowners for it and thus move with whatever speed you desire

As far as I know, approving PRs in contrib repo requires 3 approvers, 2 of them have to be maintainers. This process can sometimes last months from my experience.
Is there any documentation regarding code owners policy in contrib?

[iNikem]

I will raise this question during next Otel maintainers meetings. What you describe goes against the very idea of contrib repo and must be addressed by OpenTelemetry.

[dyladan]

@blumamir There is no documentation for contrib, you are referring to the guidelines from the core repo. In contrib, we typically have been merging with 2 reviews, only 1 of which is a maintainer.

During the maintainer meeting this week we talked about ways to close this gap. One of the ideas we considered is making the contrib maintainership a separate role from the core maintainership. Since you obviously have put a ton of time into instrumentations, would you consider taking a maintainership role for the contrib/instrumentations if it was created?

[blumamir]

Thanks @dyladan
If this role is created, I'll be glad to apply for it and to help maintain the contrib instrumentations

[dyladan]

@blumamir there isn't such a role but for now making you an approver on the repo would be a good first step while it is discussed. I know other SIGs are considering making similar changes. Are you a member of the opentelemetry org (prerequisite for any official position)? If not, I'm happy to be one of your sponsors for membership.

[blumamir]

Are you a member of the opentelemetry org (prerequisite for any official position)? If not, I'm happy to be one of your sponsors for membership.

Not yet, thank you for offering :) Looks like I need another sponsor to become opentelemetry org member. Is anyone else in this conversation willing to sponsor me for membership?

[owais]

@blumamir I'd be more than happy to. Can you please open a PR like this one: open-telemetry/community#711

[blumamir]

@blumamir I'd be more than happy to. Can you please open a PR like this one: open-telemetry/community#711

Done
open-telemetry/community#714

thanks

[pauldraper]

+1 These are really great quality. But some sort of discovery (even if a link) would make these more used.

[blumamir]

+1 These are really great quality. But some sort of discovery (even if a link) would make these more used.

Thanks. Where would you expect such a link?

[pauldraper]

Well...opentelemetry/opentelemetry-js is where I start when it comes to JS-related Otel stuff...

[blumamir]

Opentelemetry-js is the official repo from otel organization, where this one is a third-party contributions.
But we did add all the instrumentation libraries to the opentelemetry registry, and open for suggestions on how to make them more discoverable.

How did you end up finding this repo?

[pauldraper]

open-telemetry/opentelemetry-js-contrib#323 (comment)