-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use same Json schema as Java library #19
Comments
It's a good suggestion, but I don't think we can change our current format, because existing consumers would break (unless we do some versioning which is even more complicated). I think the way to go is to make it configurable. Unfortunately it's not our focus atm, but feel free to sumbit a PR. |
Stumbled over the same issue. I implemented an opt-in compatibility mode here: https://github.com/FrederikP/sns-sqs-big-payload/tree/introduce-awslabs-compatibility-optin It's hard to write an integration test because that would mean creation java resources etc. in this project. Feel free to suggest changes and I will gladly open up a PR if it helps. |
Okay we tested the compatibility mode in our environment. (sending in non nodejs component, receiving in nodejs component) and it works. |
Hi @FrederikP, sounds great, please open a PR. |
Ok. See #26 |
Released in v0.1.0 |
* fix: use correct schema for extended lib compatibility Fixes S3 reference in the message body not matching with the JSON schema of the Amazon SQS Java Extended Client library. fix #42 #19 * test: add test for producing messages in compatibility mode * refactor: align s3extendedPayloadError with the error schema * docs: document s3-extended-payload-error event
Is it possible to use same schema as
https://docs.aws.amazon.com/sns/latest/dg/large-message-payloads.html
https://docs.aws.amazon.com/AWSSimpleQueueService/latest/SQSDeveloperGuide/sqs-s3-messages.html
java libraries for SNS and SQS to be able to produce/consume using nodeJs and consume/produce using Java.
they use next Json
[ "software.amazon.payloadoffloading.PayloadS3Pointer", { "s3BucketName": "extended-client-bucket", "s3Key": "xxxx-xxxxx-xxxxx-xxxxxx" } ]
or at least maybe make it configurable
Thanks
The text was updated successfully, but these errors were encountered: