Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unknown option should exit code non 0 #34

Closed
bricewge opened this issue Jun 8, 2019 · 0 comments · Fixed by #35 or #37
Closed

Unknown option should exit code non 0 #34

bricewge opened this issue Jun 8, 2019 · 0 comments · Fixed by #35 or #37
Assignees
@aspiers
Labels
bug

Comments

@bricewge
Copy link
Contributor

bricewge commented Jun 8, 2019

stow --foo correctly displays that it doesn't know the option Unknown option: foo but the exit code is still 0. It should be non 0 like other common commands.
@bricewge bricewge mentioned this issue Jun 11, 2019
Merged
@aspiers aspiers added the bug label Jun 25, 2019
@aspiers aspiers self-assigned this Jun 25, 2019
aspiers added a commit that referenced this issue Jun 25, 2019
@aspiers
Return non-zero exit code when invalid option is specified (#34)
7aa9477 
Also add a unit test for this.

Fixes #34
aspiers added a commit that referenced this issue Jun 25, 2019
@aspiers
Return non-zero exit code when invalid option is specified (#34)
e79c593 
Also add a unit test for this.

Fixes #34: #34
@aspiers aspiers mentioned this issue Jun 25, 2019
Merged
aspiers added a commit that referenced this issue Jun 25, 2019
@aspiers
Merge pull request #37 from aspiers/invalid-option-exit-code
a70c60e 
Return non-zero exit code when invalid option is specified (#34)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aspiers aspiers

Labels
bug
Projects
None yet
Milestone
No milestone
2 participants
@aspiers @bricewge