Implement Adobe IO provider #573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/AspNet.Security.OAuth.AdobeIO/AdobeIOAuthenticationDefaults.cs
Outdated
Show resolved
Hide resolved
src/AspNet.Security.OAuth.AdobeIO/AdobeIOAuthenticationDefaults.cs
Outdated
Show resolved
Hide resolved
src/AspNet.Security.OAuth.AdobeIO/AdobeIOAuthenticationOptions.cs
Outdated
Show resolved
Hide resolved
src/AspNet.Security.OAuth.AdobeIO/AdobeIOAuthenticationOptions.cs
Outdated
Show resolved
Hide resolved
src/AspNet.Security.OAuth.AdobeIO/AspNet.Security.OAuth.AdobeIO.csproj
Outdated
Show resolved
Hide resolved
test/AspNet.Security.OAuth.Providers.Tests/AdobeIO/AdobeIOTests.cs
Outdated
Show resolved
Hide resolved
|
All done :) |
src/AspNet.Security.OAuth.AdobeIO/AdobeIOAuthenticationOptions.cs
Outdated
Show resolved
Hide resolved
src/AspNet.Security.OAuth.AdobeIO/AspNet.Security.OAuth.AdobeIO.csproj
Outdated
Show resolved
Hide resolved
…O.csproj Co-authored-by: Martin Costello <martin@martincostello.com>
Co-authored-by: Martin Costello <martin@martincostello.com>
martincostello
approved these changes
Jul 4, 2021
|
Thanks for your contribution @biltongza 🎁 - could you verify it works in your application and with the real AdobeIO service using the If all working as expected, we can make a 5.0.8 release and push the provider to NuGet.org. |
|
I did a test of a local build before creating the PR, did another one now with the myget build and it's working fine. Do you need any evidence? |
|
Great thanks - no, I'll take your word for it 😃 It's just we've had a few new providers recently where they weren't tested with the real service by the contributors and we had to do patch releases the day after they first shipped. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement Adobe IO authentication provider.
https://www.adobe.io/authentication/auth-methods.html#!AdobeDocs/adobeio-auth/master/AuthenticationOverview/AuthenticationGuide.md