Add Xiaomi provider #675
Add Xiaomi provider #675
Conversation
src/AspNet.Security.OAuth.XiaoMi/XiaoMiAuthenticationHandler.cs
Outdated
Show resolved
Hide resolved
src/AspNet.Security.OAuth.XiaoMi/XiaoMiAuthenticationHandler.cs
Outdated
Show resolved
Hide resolved
src/AspNet.Security.OAuth.XiaoMi/XiaoMiAuthenticationHandler.cs
Outdated
Show resolved
Hide resolved
src/AspNet.Security.OAuth.XiaoMi/XiaoMiAuthenticationHandler.cs
Outdated
Show resolved
Hide resolved
src/AspNet.Security.OAuth.XiaoMi/XiaoMiAuthenticationHandler.cs
Outdated
Show resolved
Hide resolved
src/AspNet.Security.OAuth.XiaoMi/XiaoMiAuthenticationOptions.cs
Outdated
Show resolved
Hide resolved
test/AspNet.Security.OAuth.Providers.Tests/XiaoMi/XiaoMiTests.cs
Outdated
Show resolved
Hide resolved
test/AspNet.Security.OAuth.Providers.Tests/XiaoMi/XiaoMiTests.cs
Outdated
Show resolved
Hide resolved
|
Just one outstanding comment, otherwise this looks good: #675 (comment) |
|
Thanks for your contribution! In Europe and in the USA, the "official" casing is generally "Xiaomi", not "XiaoMi". Any chance you could change that? |
|
|
||
| var address = QueryHelpers.AddQueryString(Options.TokenEndpoint, tokenRequestParameters); | ||
|
|
||
| using var response = await Backchannel.GetAsync(address, Context.RequestAborted); |
There was a problem hiding this comment.
I see the documentation says the token endpoint uses GET, but have you tried using POST to see what it does?
There was a problem hiding this comment.
Thanks, I will rename to Xiaomi, I didn't try to use post request, can you tell me the necessity of using it? I can try.
| @@ -0,0 +1,20 @@ | |||
| /* | |||
There was a problem hiding this comment.
I can't comment on file-names in git diffs, but you also need to fix the casing of the directory and file names.
There was a problem hiding this comment.
This is why the ubuntu build is failing due to the case-sensitive file system.
There was a problem hiding this comment.
I confirmed that it was all renamed, but nothing changed after the commit, and I don't know why, so I decided to re-commit, and I will update the README to add the new provider to the table.
There was a problem hiding this comment.
Windows is a case-insensitive file system, so just changing the case in the file names won't make them change in git.
You can achieve a rename either by renaming to something else and then back to the intended casing, e.g. XiaoMiAuthenticationOptions2 -> XiaomiAuthenticationOptions, or by using the git mv command, e.g. git mv XiaoMiAuthenticationOptions.cs XiaomiAuthenticationOptions.cs.
There was a problem hiding this comment.
I know the first way but don't like it, I will try the second way in the future, thanks.
Add an OAuth 2.0 Xiaomi provider.