-
Notifications
You must be signed in to change notification settings - Fork 533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SuperOffice provider: Support dynamic subdomains (UserInfo endpoint) #755
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nHandler.cs Co-authored-by: Martin Costello <martin@martincostello.com>
Add Huawei provider. Signed-off-by: Vicente Yu <^@^>
- Rename `FetchNickName` to `FetchNickname`. - Add missing XML documentation. - Remove documentation copied from Huawei that isn't provider-specific.
Bump version to 6.0.14 for next release.
Remove `DisablePackageBaselineValidation` for the Huawei provider.
Add Smartsheet provider.
Bump version to 6.0.15 for next release.
* Bump version to 7.0.0 Bump version to 7.0.0 for next major release. * Remove redundant overrides Remove redundant method overrides. Resolves #636. * Update to ASP.NET Core 7 preview 1 Update to target .NET 7 and ASP.NET Core 7 preview 1. * Bump M.IdentityModel.Protocols.OpenIdConnect Bump Microsoft.IdentityModel.Protocols.OpenIdConnect to the latest version to benefit from using the new ValidateTokenAsync() method. * Update to ASP.NET Core 7 preview 2 Update to preview 2 of ASP.NET Core 7. * Add Naver provider (#667) * Add Naver Provider (#665) * Add Naver Provider * Bump version to 6.0.6 Bump version to 6.0.6 for next release. Co-authored-by: Chris Sung <chris.sung@nsuslab.com> * Update to ASP.NET Core 7 preview 3 (#669) Update to preview 3 of ASP.NET Core 7. * Update to ASP.NET Core 7 preview 4 Update to preview 4 of ASP.NET Core 7. * Update to ASP.NET Core 7 preview 5 Update to preview 5 of ASP.NET Core 7. * Remove Weibo email scope Remove `email` from the default Weibo scopes. Resolves #692. * Update to ASP.NET Core 7 preview 6 Update to preview 6 of ASP.NET Core 7. * Update to ASP.NET Core 7 preview 7 Update to preview 7 of ASP.NET Core 7. * Remove PackageValidationBaselineVersion Remove `PackageValidationBaselineVersion` overrides. * Update to ASP.NET Core 7 RC 1 Update to release candidate 1 of ASP.NET Core 7. * Update to ASP.NET Core 7 RC 2 Update to release candidate 2 of ASP.NET Core 7. * Update Arcade Update Arcade to the latest v7 version used by ASP.NET Core. * Set executable bit Set the executable bit for the new Arcade shell scripts. * Update StackExchange provider - Use the JSON token exchange endpoint. - Use the domains given in the API documentation. - Update to version 2.3 of the API. - Align the provider with the request key being required. - Validate the Site once, rather than per request. * Update Shouldly Update to the latest release of Shouldly. * Revert build workflow changes Revert changes to build for the `dev-7.0.0` branch. * Revert PreRelease properties Revert changes to the `PreRelease*` MSBuild properties for .NET 7 previews. * Update to ASP.NET Core 7 Update to the stable release of ASP.NET Core 7. * Remove PackageValidationBaselineVersion Remove PackageValidationBaselineVersion for new v6 packages. Co-authored-by: Chris Sung <chris.sung@nsuslab.com>
- Bump version to 7.0.1 for next release. - Re-enable package baseline validation.
* Revert "Update src/AspNet.Security.OAuth.SuperOffice/SuperOfficeAuthenticationHandler.cs" This reverts commit 8388be4. * Revert "Decontruct result from getting tenant id and webapi url." This reverts commit b2f8527. * Revert "Added flexible subdomain support for UserInfo endpoint. Updated docs link." This reverts commit 2ec4b74.
Hum, the history seems weird (and there are merge conflicts). Any chance you could rebase your PR on top of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Follow-up to PR
This PR enabled backwards compatibility with current and very near future changes with how the SuperOffice provider resolves UserInfo endpoint data.
This PR also updates README link to the docs.
This also fixes the previously broken tests.