Added support for dynamic userinfo subdomains #756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kevinchalet, yes, that last PR attempt was a bit of a mystery... This one is cleaner. |
src/AspNet.Security.OAuth.SuperOffice/SuperOfficeAuthenticationHandler.cs
Outdated
Show resolved
Hide resolved
martincostello
approved these changes
Jan 30, 2023
martincostello
pushed a commit
that referenced
this pull request
Apr 16, 2023
* Fixed tests, added support for dynamic userinfo subdomains * Update SuperOfficeAuthenticationHandler.cs --------- Co-authored-by: Tony Yates <tony@anthonyyates.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Follow-up to PR
This PR enabled backwards compatibility with current and very near future changes with how the SuperOffice provider resolves UserInfo endpoint data.
This PR also updates README link to the docs.
This also fixes the previously broken tests.