Use C# 12 features #806
Merged
Use C# 12 features #806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
martincostello
commented
Oct 1, 2023
martincostello
commented
- Use primary constructors where relevant.
- Use collection literals where relevant.
- Add helper method to reduce duplicative tests.
- Apply some IDE suggestions.
- Remove redundant using statements.
- Fix some typos.
- Hide shared files from the Visual Studio project explorer.
- Use primary constructors in test classes. - Use collection literals - Add helper method to reduce duplicative tests. - Fix some typos.
Update test missed from refactor in previous commit.
Hide shared files from the Visual Studio project explorer.
- Use primary constructors where relevant. - Use collection literals where relevant. - Apply some IDE suggestions. - Remove redundant using statements. - Fix some typos.
Remove `<remarks>` from class documentation when primary constructor is used.
kevinchalet
approved these changes
Oct 2, 2023
| { | ||
| new AuthenticationToken() { Name = "access_token", Value = tokens.AccessToken }, | ||
| }; | ||
| List<AuthenticationToken> authTokens = |
There was a problem hiding this comment.
Assuming we like the new syntax mostly for its terseness, maybe we should put everything on the same line when there's a single item added?
List<AuthenticationToken> authTokens = [new() { Name = "access_token", Value = tokens.AccessToken }];There was a problem hiding this comment.
I'm not going to change this one, at least for now, as doing so needs me to suppress SA1010 due to this bug.
src/AspNet.Security.OAuth.Apple/Internal/DefaultAppleClientSecretGenerator.cs
Outdated
Show resolved
Hide resolved
Code reviewer prefers the older style.
Remove property and use constructor parameter to match `hostingEnvironment`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.