Fix duplicated query string parameters for VSO/AzDo provider #814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix query string parameters being duplicated if `AuthorizationEndpoint` contains any user-added query string parameters.
Tratcher
reviewed
Nov 8, 2023
| return QueryHelpers.AddQueryString(Options.AuthorizationEndpoint, query); | ||
| // Remove the query and re-add with the edit so that the parameters are not duplicated. | ||
| // See https://github.com/dotnet/aspnetcore/issues/47054 for more context. | ||
| challengeUri.Query = string.Empty; |
There was a problem hiding this comment.
Something like:
Suggested change
| challengeUri.Query = string.Empty; | |
| challengeUri.Query = QueryString.Create(query); | |
| return callengeUri.Uri.AbsoluteUri; |
Apply code review suggestions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix query string parameters being duplicated if
AuthorizationEndpointcontains any user-added query string parameters.If this change looks good, I can look at making a similar change to the Google provider for dotnet/aspnetcore#47054.
/cc @Tratcher