Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging API changes #148

Open
BrennanConroy opened this issue Jan 28, 2016 · 0 comments
Open

Logging API changes #148

BrennanConroy opened this issue Jan 28, 2016 · 0 comments

Comments

@BrennanConroy
Copy link
Member

The Log... functions are now in 3 flavors

  • Log....(this ILogger logger, EventId eventId, Exception exception, string message, params object[] args);
  • Log....(this ILogger logger, EventId eventId, string message, params object[] args);
  • Log....(this ILogger logger, string message, params object[] args);

ILogValues was removed and we are using IReadOnlyList<KeyValuePair<string, object>> instead

void Log(LogLevel logLevel, int eventId, object state, Exception exception, Func<object, Exception, string> formatter) is now void Log<TState>(LogLevel logLevel, EventId eventId, TState state, Exception exception, Func<TState, Exception, string> formatter)

The default MessageFormatter now only displays the string value of the state passed in

See the original issue aspnet/Logging#331

For discussion use aspnet/Logging#350

@aspnet aspnet locked and limited conversation to collaborators Jan 28, 2016
@BrennanConroy BrennanConroy added this to the 1.0.0-rc2 milestone Jan 28, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant