Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CI images #557

Merged
merged 2 commits into from
Nov 20, 2022
Merged

Update CI images #557

merged 2 commits into from
Nov 20, 2022

Conversation

dougbu
Copy link
Member

@dougbu dougbu commented Nov 16, 2022 •
edited
Loading

  • remove Ubuntu 18.04 on Ubuntu 18.04 Docker use
  • use consolidated Windows build images

@dougbu dougbu requested review from JamesNK and a team November 16, 2022 01:36
@dougbu
Copy link
Member Author

dougbu commented Nov 16, 2022

/cc @michellemcdaniel

But note this repo seems to need a Windows image update as well. /fyi @MattGal

dougbu
dougbu commented Nov 16, 2022
View reviewed changes
azure-pipelines.yml Outdated Show resolved Hide resolved
MattGal
MattGal approved these changes Nov 16, 2022
View reviewed changes
Copy link

@MattGal MattGal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, probably worth trying your build directly without container though as it will speed it up and be a single use machine either way.

@dougbu dougbu changed the title Use simpler Docker tag Update CI images Nov 16, 2022
@dougbu
Copy link
Member Author

dougbu commented Nov 16, 2022

Updated the title and description of this PR to reflect what it's now doing. Amounts to removing Docker use and fixing the Windows image choices.

@dougbu dougbu merged commit a7080f6 into aspnet:main Nov 20, 2022
@dougbu dougbu deleted the dougbu/docker.tag branch November 20, 2022 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesNK JamesNK JamesNK approved these changes

@MattGal MattGal MattGal approved these changes

@michellemcdaniel michellemcdaniel michellemcdaniel approved these changes

Assignees
No one assigned
Labels
area-infrastructure
Projects
None yet
Milestone
No milestone
4 participants
@dougbu @JamesNK @MattGal @michellemcdaniel