Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recreate package-lock.json files #581

Merged
merged 1 commit into from
Feb 24, 2023
Merged

Conversation

dougbu
Copy link
Member

@dougbu dougbu commented Feb 24, 2023

  • bump all resolved dependencies to latest compatible versions
    • re-resolve everything but don't change any package.json files
  • bump json5, loader-utils, and minimatch in particular
    • all the subject of recent Dependabot PRs
  • also add always-auth=true to .npmrc files
    • required to ingest packages into dotnet-public-npm

Note: Unable to use just one .npmrc file here

  • appears yarn looks up the tree by default but npm does not

- bump all resolved dependencies to latest compatible versions
  - re-resolve everything but don't change any package.json files
- bump `json5`, `loader-utils`, and `minimatch` in particular
  - all the subject of recent Dependabot PRs
- also add `always-auth=true` to .npmrc files
  - required to ingest packages into `dotnet-public-npm`

Note: Unable to use just one .npmrc file here
- appears `yarn` looks up the tree by default but `npm` does not
@mkArtakMSFT
Copy link
Member

Thanks @dougbu.
One of the major changes I notice here is that the source for all the packages have switched from registry.npmjs.org to pkgs.dev.azure.com/dnceng/public. I assume this is intentional? Just wanted to make sure that's the case.

@dougbu
Copy link
Member Author

dougbu commented Feb 24, 2023

Thanks @dougbu. One of the major changes I notice here is that the source for all the packages have switched from registry.npmjs.org to pkgs.dev.azure.com/dnceng/public. I assume this is intentional? Just wanted to make sure that's the case.

Yes, that was intentional. The .npmrc files were meant to ensure we resolved our npm packages from dotnet-public-npm. Without this change, that wasn't put into practice.

@dougbu dougbu merged commit cbca159 into aspnet:main Feb 24, 2023
@dougbu dougbu deleted the dougbu/central.npmrc branch February 24, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants