Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blazor Default Server-Side Template Uses Deprecated app HTML Tag #11013

Closed
Mike-E-angelo opened this issue Jun 8, 2019 · 10 comments
Closed

Blazor Default Server-Side Template Uses Deprecated app HTML Tag #11013

Mike-E-angelo opened this issue Jun 8, 2019 · 10 comments
Labels
affected-most This issue impacts most of the customers area-blazor Includes: Blazor, Razor Components bug This issue describes a behavior which is not expected - a bug. severity-nice-to-have This label is used by an internal tool
Milestone

Comments

@Mike-E-angelo
Copy link

Mike-E-angelo commented Jun 8, 2019

Describe the bug

The default server-side Blazor template appears to include a deprecated HTML5 tag: the app tag.

To Reproduce

  1. Create a server-side template
  2. Navigate to ~/Pages/_Host.cshtml
  3. Deprecated app tag should be on line 25.

Expected behavior

Something besides an app tag or no app tag at all. 😊

Perhaps <div class="application">...</div> ?

Additional context

https://html.com/tags/app/

@analogrelay analogrelay added the area-blazor Includes: Blazor, Razor Components label Jun 10, 2019
@mkArtakMSFT mkArtakMSFT added bug This issue describes a behavior which is not expected - a bug. PRI: 2 - Preferred labels Jun 10, 2019
@mkArtakMSFT mkArtakMSFT added this to the 3.1.0 milestone Jun 10, 2019
@mkArtakMSFT
Copy link
Member

Closing this as this seems to be supported and people can choose to use the proposed approach.

@Mike-E-angelo
Copy link
Author

@mkArtakMSFT "seems to be" or is? Based on the provided link this is not a supported tag and if there is support it is probably for legacy reasons. Providing a link with more information would be greatly appreciated.

Also, I am also in the dark with regards to the proposed approach. Shedding some additional context would be greatly appreciated as well. Thanks in advance.

@Mike-E-angelo
Copy link
Author

A couple of obvious concerns here:

  • The templates here are used by every developer who will touch Blazor. They should be providing the best guidance. These templates will, of course, be copy/pasted to the ends of Earth so they should have the best guidance and implementation possible.
  • By using deprecated/inaccurate HTML5 or simply not following the HTML5 specification, you make MSFT look bad.
  • Subsequently, other non-MSFT HTML5 developers will see this and wonder why you are using non-compliant tags and question your chops. If you cannot use compliant tags, what else are you doing that's questionable? Of course, they will not say anything as they will prefer you to maintain your ignorance as much as possible.

@mkArtakMSFT
Copy link
Member

@Mike-EEE we're a small team trying to focus our efforts on critical and most important issues only. This one is not really a blocker in any way, and given the priority of it realize that we won't get to this even in the near future.
The suggestion you have with the <div>... tag is an option you can build.

@Mike-E-angelo
Copy link
Author

Cool, thank you for the extended context and explanation, @mkArtakMSFT. Would you be willing to allow a PR around this if I can figure out how to make one? 😇

@mkArtakMSFT mkArtakMSFT modified the milestones: 3.1.0, 5.0.0 Aug 14, 2019
@mkArtakMSFT mkArtakMSFT reopened this Aug 14, 2019
@mkArtakMSFT
Copy link
Member

That would be great.
@SteveSandersonMS what do you think it would make sense to replace the current <app> tag with?

@Mike-E-angelo
Copy link
Author

Mike-E-angelo commented Aug 17, 2019

FWIW I have created a draft (in every sense of the word 😆) PR for this, primarily to test the capacity of doing so, but also to gauge where exactly I should be editing and which files I should be modifying. There appears to be several places throughout the solution where <app /> is used, so before going through all of them my thought was to do one and then we can take it from there.

As for the actual solution, I have applied my suggestion of the <div class="application" /> as above but, of course, is subject to change if we can think of something better.

Thank you in advance for any additional assistance and/or consideration around this issue. 👍

@mkArtakMSFT
Copy link
Member

We'll remove the app tag completely.

@mkArtakMSFT
Copy link
Member

We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. However, keep in mind that there are many other high priority features with which it will be competing for resources.

@SteveSandersonMS SteveSandersonMS added affected-most This issue impacts most of the customers severity-nice-to-have This label is used by an internal tool labels Oct 9, 2020 — with ASP.NET Core Issue Ranking
@Mike-E-angelo
Copy link
Author

Looks like this is no longer an issue in the latest 5.0.0 templates:

I will close this issue now.

But before I do so, I wanted to give a GINORMOUS shout of respect and appreciation for all your diligent work out there. I am finally coding my first client application since 2011. Think of that! Nearly a full decade. And yes, if we're talking 2011 we're talking Silverlight.

I have been nose/brain-deep into Blazor for the past year and it has been truly something. HTML isn't as pretty as Xaml, of course, but the architecture/design of Blazor far and away makes up for it.

That parsing engine, tho. https://twitter.com/Mike_E_angelo/status/1322595036006068224

Anyway, thanks again, team! Continue the greatness. 🙏

@ghost ghost locked as resolved and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affected-most This issue impacts most of the customers area-blazor Includes: Blazor, Razor Components bug This issue describes a behavior which is not expected - a bug. severity-nice-to-have This label is used by an internal tool
Projects
None yet
Development

No branches or pull requests

5 participants