-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for .webmanifest file extension #2442
Comments
From @Tratcher on Friday, October 27, 2017 4:13:03 PM Is there a spec reference? |
From @madskristensen on Friday, October 27, 2017 4:24:22 PM https://w3c.github.io/manifest/#media-type-registration shows the content type Sorry, I should have added this when I opened the bug |
From @RehanSaeed on Monday, October 30, 2017 2:59:39 AM Just saw this issue, I already raised aspnet/StaticFiles#221 to fix this. |
Backlogging this. cc @glennc FYI. |
There's an additional imperative for this now, because the usual work-around of adding the required mapping to a This seems to be because if you pass Could we please just have the mapping entry? Someone even filed a one-line PR for this over two years ago #221 - if just seemed to get lost somehow. |
@danroth27 @anurse We're getting more hits on this. See the linked PR #7664. |
I'd support reviving this. There's an RFC defining this mapping (file extension -> mime type) right? |
It's documented by w3c, but not registered with IANA. |
@SteveSandersonMS How are we handling the manifest media type currently in the new PWA support for Blazor WebAssembly? |
@danroth27 We call it manifest.json so it uses the default JSON media type. We can switch it to be a .webmanifest file in the future when ASP.NET Core understands that by default. In the short term it should make no difference: https://stackoverflow.com/questions/52129281/manifest-json-vs-manifest-webmanifest |
(Emphasis added) This seems like a Blazor problem worth investigating (@SteveSandersonMS @danroth27 ). I'm sending a PR to add the content type mapping. |
From @madskristensen on Friday, October 27, 2017 3:57:16 PM
This is used in Progressive Web Apps (PWAs) for the manifest JSON file.
The content type should be
application/manifest+json
Copied from original issue: aspnet/StaticFiles#219
The text was updated successfully, but these errors were encountered: