Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add benchmarks for auth infrastructure and hot paths #7162

Closed
Tratcher opened this issue Jan 31, 2019 · 9 comments
Closed

Add benchmarks for auth infrastructure and hot paths #7162

Tratcher opened this issue Jan 31, 2019 · 9 comments
Labels
affected-medium This issue impacts approximately half of our customers area-auth Includes: Authn, Authz, OAuth, OIDC, Bearer ✔️ Resolution: Duplicate Resolved as a duplicate of another issue Perf severity-minor This label is used by an internal tool Status: Resolved task
Milestone

Comments

@Tratcher
Copy link
Member

One area we haven't tried to benchmark yet is AuthN and AuthZ.

High priority as these happen on most requests:

  • AuthenticationMiddleware, handler resolution, etc..
  • Authorization policies
  • Cookie Auth, decrypting, deserializing, and verifying
  • Jwt bearer auth, deserializing, and verifying

Low priority, these only happen on a small percentage of requests:

  • Cookie creation and refresh, seralizing, encrypting
  • OAuth and OIDC challenges and logins
@Tratcher Tratcher added task area-auth Includes: Authn, Authz, OAuth, OIDC, Bearer area: Performance labels Jan 31, 2019
@muratg muratg added this to the 3.0.0 milestone Jan 31, 2019
@muratg
Copy link
Contributor

muratg commented Jan 31, 2019

Putting this in 3.0.0 timeline. We'll try to see our perf characteristics here as the first step.

@davidfowl davidfowl modified the milestones: 3.0.0, 3.0.0-preview4 Feb 2, 2019
@davidfowl
Copy link
Member

Putting this in a specific preview so it doesn't happen at the end when we can't react.

@Eilon Eilon modified the milestones: 3.0.0-preview4, 3.0.0-preview7 Mar 26, 2019
@Eilon
Copy link
Member

Eilon commented Mar 26, 2019

Moving to a later preview. We should at least check Cookie Auth because it runs on every request. The other middlesware don't run as often so we're less concerned about their per-request perf.

@davidfowl
Copy link
Member

We should still know the performance of the code we wrote. Some of it was just lazy and could easily be better even if its doesn’t happen as often.

What about JWT?

@Eilon
Copy link
Member

Eilon commented Mar 27, 2019

We're trying to prioritize the work, so we're open to adjusting priorities based on feedback.

@davidfowl
Copy link
Member

We should do both JWT and Cookie then. Both Microbenchmarks and Full end to end benchmarks.

@rynowak
Copy link
Member

rynowak commented Mar 27, 2019

I hope you're ready to be sad about the perf of the JWT code 😆

@Tratcher Tratcher added affected-medium This issue impacts approximately half of our customers severity-minor This label is used by an internal tool labels Nov 10, 2020 — with ASP.NET Core Issue Ranking
@Pilchie
Copy link
Member

Pilchie commented Mar 30, 2021

@sebastienros and @HaoK haven't you been looking at this already?

@HaoK
Copy link
Member

HaoK commented Mar 30, 2021

Yep dupe of #27220

@HaoK HaoK closed this as completed Mar 30, 2021
@HaoK HaoK added the ✔️ Resolution: Duplicate Resolved as a duplicate of another issue label Mar 30, 2021
@ghost ghost added the Status: Resolved label Mar 30, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Apr 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affected-medium This issue impacts approximately half of our customers area-auth Includes: Authn, Authz, OAuth, OIDC, Bearer ✔️ Resolution: Duplicate Resolved as a duplicate of another issue Perf severity-minor This label is used by an internal tool Status: Resolved task
Projects
None yet
Development

No branches or pull requests

9 participants