-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add benchmarks for auth infrastructure and hot paths #7162
Comments
Putting this in 3.0.0 timeline. We'll try to see our perf characteristics here as the first step. |
Putting this in a specific preview so it doesn't happen at the end when we can't react. |
Moving to a later preview. We should at least check Cookie Auth because it runs on every request. The other middlesware don't run as often so we're less concerned about their per-request perf. |
We should still know the performance of the code we wrote. Some of it was just lazy and could easily be better even if its doesn’t happen as often. What about JWT? |
We're trying to prioritize the work, so we're open to adjusting priorities based on feedback. |
We should do both JWT and Cookie then. Both Microbenchmarks and Full end to end benchmarks. |
I hope you're ready to be sad about the perf of the JWT code 😆 |
@sebastienros and @HaoK haven't you been looking at this already? |
Yep dupe of #27220 |
One area we haven't tried to benchmark yet is AuthN and AuthZ.
High priority as these happen on most requests:
Low priority, these only happen on a small percentage of requests:
The text was updated successfully, but these errors were encountered: