Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix core-setup URI #8641

Merged
merged 1 commit into from
Mar 20, 2019
Merged

Fix core-setup URI #8641

merged 1 commit into from
Mar 20, 2019

Conversation

dougbu
Copy link
Member

@dougbu dougbu commented Mar 19, 2019

No description provided.

@dougbu
Copy link
Member Author

dougbu commented Mar 19, 2019

@BrennanConroy you asked about this URI and @mmitche has let us know it was incorrect. So, you're volunteered 😺

@mmitche
Copy link
Member

mmitche commented Mar 19, 2019

It's not technically incorrect, just that we should only use the internal uri for commits that are not availabe in the open.

@Eilon Eilon added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Mar 19, 2019
@dougbu dougbu merged commit 7c3d249 into master Mar 20, 2019
@dougbu dougbu deleted the dougbu/fix.core-setup branch March 20, 2019 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrennanConroy BrennanConroy BrennanConroy approved these changes

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dougbu @mmitche @BrennanConroy @Eilon