Skip to content
This repository has been archived by the owner on Dec 20, 2018. It is now read-only.

Enabled rule attribute never used #139

Closed
BrennanConroy opened this issue Oct 18, 2016 · 2 comments
Closed

Enabled rule attribute never used #139

BrennanConroy opened this issue Oct 18, 2016 · 2 comments

Comments

@jkotalik
Copy link
Contributor

That issues doesn't fix the enable rule never being used. It should be added here:
https://github.com/aspnet/BasicMiddleware/blob/dev/src/Microsoft.AspNetCore.Rewrite/Internal/IISUrlRewrite/UrlRewriteRuleBuilder.cs#L31
as a check to see if we should be creating the rule in the first place.

@muratg muratg added this to the 1.1.0 milestone Oct 19, 2016
@mikaelm12
Copy link
Contributor

The enabled flag on the builder is actually being used here to determine if each rule should be added

if (builder.Enabled)
{
result.Add(builder.Build());
}

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants