This repository has been archived by the owner on Dec 20, 2018. It is now read-only.
Fixed Enable and negate flag issue. #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Actually, this doesn't fix the enabled issue, see Justin's comment on the issue. Also, add a couple tests |
| @@ -38,6 +38,11 @@ private void ParseRules(XElement rules, IList<IISUrlRewriteRule> result) | |||
| return; | |||
| } | |||
|
|
|||
| if(string.Equals(rules.Name.ToString(), "GlobalRules", StringComparison.OrdinalIgnoreCase)) | |||
|
It does fix the enabled flag issue. Justin was mistaken |
Tratcher
reviewed
Oct 19, 2016
| else | ||
| { | ||
| builder.Enabled = enabled; | ||
| } |
There was a problem hiding this comment.
if !Enabled, consider not parsing the rest of the rule. That would allow users to disable rules that use features we don't support, rather than having to delete them.
There was a problem hiding this comment.
That's a good idea. The only thing is that if we don't parse the rest of the rule we allow the user to enter invalid rules since the checking isn't happening. Not a huge deal since the rule won't be enabled bit still something to consider
|
Ping @Tratcher @BrennanConroy |
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issues #138 and #139.
I also made the middleware throw when global rules are present since we don't actually handle them properly with the current implementation.
@Tratcher @muratg @BrennanConroy