Skip to content
This repository has been archived by the owner on Dec 20, 2018. It is now read-only.

Add trackAllCaptures for Back References in Url Rewrite #141

Closed
BrennanConroy opened this issue Oct 19, 2016 · 6 comments
Closed

Add trackAllCaptures for Back References in Url Rewrite #141

BrennanConroy opened this issue Oct 19, 2016 · 6 comments

Comments

@BrennanConroy
Copy link
Member

BrennanConroy commented Oct 19, 2016

e.g.

<condtions trackAllCaptures="true">
  <add input="{QUERY_STRING}" pattern="id=(20)" />
  <add input="{HTTP_HOST}" pattern="(.*)" />
</conditions>
<action type="Redirect" url="https://{C:2}" />

@mikaelm12

@BrennanConroy
Copy link
Member Author

BrennanConroy commented Oct 19, 2016

Remember, trackAllCaptures is part of the back reference feature

builder.AddUrlConditions(grouping, trackingAllCaptures);

@BrennanConroy
Copy link
Member Author

The correct name is trackAllCaptures not trackingAllCaptures

public const string TrackingAllCaptures = "trackingAllCaptures";

@BrennanConroy BrennanConroy changed the title Add Back References in Url Rewrite Add trackAllCaptures for Back References in Url Rewrite Oct 20, 2016
@BrennanConroy
Copy link
Member Author

BackReference uses RegularExpressions.GroupCollection which doesn't have additive operators, so we'll have to change the structure used to contain the back references.

@muratg muratg added this to the 1.1.0 milestone Oct 31, 2016
@muratg
Copy link
Contributor

muratg commented Oct 31, 2016

@mikaelm12 Let's fix the enum name in 1.1. And investigate the back referencing issue. If the potential fix for that is not breaking, we can do it in 1.2 instead.

@mikaelm12
Copy link
Contributor

Okay. I changed the enum in #166
This bug should be moved to 1.2 though

@mikaelm12
Copy link
Contributor

Added in #178

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants