This repository has been archived by the owner on Dec 20, 2018. It is now read-only.
XML Comments and Feedback from 1-on-1 with Nate #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@muratg for naming. |
| @@ -8,15 +8,18 @@ | |||
|
|
|||
| namespace Microsoft.AspNetCore.Rewrite | |||
| { | |||
| public static class ModRewriteOptionsExtensions | |||
| /// <summary> | |||
| /// Apache Mod rewrite extensions on top of the <see cref="RewriteOptions"/> | |||
There was a problem hiding this comment.
nit: "Apache mod_rewrite"
| { | ||
| public class ChangeEnvironmentPreAction : PreAction | ||
| public class ChangeEnvironmentPreAction : UrlAction |
There was a problem hiding this comment.
Can you also rename the class "ChangeEnvironmentPreAction" => "ChangeEnvironmentAction"?
|
⌚ |
|
🆙 📅 |
| { | ||
| public class ChangeEnvironmentPreAction : PreAction | ||
| public class ChangeEnvironmentPreAction : UrlAction |
There was a problem hiding this comment.
Nit: sync class name to filename. => "ChangeEnvironmentAction"
|
LGTM. |
|
I found a bug for flags, didn't check for the OR flag. Just going to package it here |
|
|
from the naming point of view. | @@ -81,6 +80,7 @@ public override void ApplyRule(RewriteContext context) | |||
| else | |||
| { | |||
| request.Path = PathString.FromUriComponent(ForwardSlash + result); | |||
|
|
|||
There was a problem hiding this comment.
Nit: delete empty line
|
|
jkotalik
force-pushed
the
ZestyBread/XML
branch
from
6a9c2e6
to
af2c1ac
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Couple of key things: