Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Fortunes message required for EF Core #1662

Merged
merged 1 commit into from
Apr 22, 2021

Conversation

roji
Copy link
Member

@roji roji commented Apr 22, 2021

Makes EF Core skip the IsDBNull check

RPS: 91,423 -> 92,696 (~1.4%)

/cc @ajcvickers

Makes EF Core skip the IsDBNull check
@ajcvickers
Copy link
Member

@roji It's great to see optimizations like not always calling isDBNull for required columns having a real impact like this!

/cc @aspnet/efteam

roji added a commit to roji/AspNetBenchmarks that referenced this pull request Apr 30, 2021
roji added a commit to roji/AspNetBenchmarks that referenced this pull request May 4, 2021
roji added a commit to roji/AspNetBenchmarks that referenced this pull request May 4, 2021
Makes EF Core skip the IsDBNull check
roji added a commit to roji/AspNetBenchmarks that referenced this pull request May 5, 2021
@roji roji deleted the FortunesMessageRequired branch September 23, 2022 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants