-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ASP.NET Core Blazor Language Services 15.7.10222 crash VS #16193
Comments
@aguacongas Output |
|
It occurs each time I try to update : <UserName Class="form-control" Value=@userName OnError=@OnError></UserName> to <UserName Class="form-control" bind-Value=@userName OnError=@OnError></UserName> |
@rynowak This does repro. After creating the minimal |
I'm having also troubles loading my blazor solution, this was working fine with 0.1. Separate (without the solution) the blazor project loads fine. |
@floreseken delete .vs folder, it should fix it |
I unfortunately won't have access to a windows machine until Saturday. I'm at a conference and mine blew up. I'll try to write a test that reproduces the issue |
Thanks @aguacongas ! that worked. |
@rynowak No worries - not urgent. Update: Simpler repro is:
|
I haven't been able to write a unit test that reproduces the problem. I don't have access to a VS environment right now :( The exception is here: https://github.com/aspnet/Blazor/blob/dev/src/Microsoft.AspNetCore.Blazor.Razor.Extensions/BlazorDesignTimeNodeWriter.cs#L424 My bet is that something in the bind lowering phase is rewriting this node incorrectly. The reason why tabbing back and away causes the crash is that VS uses that as a trigger to force the generated code to update. Normal edits don't trigger a full code generation pass, they attempt to reuse and modify the existing codegen where possible. |
I'm having the same issue. I have per the example in the Blazor 0.2.0 release notes on MSDN. When I type Component code (reduced for clarity)
Index.cshtml
|
I hit this a couple of times as well when investigating https://github.com/aspnet/Blazor/issues/610 |
The issue here is that we were missing tests for the design time code path. We have tests that the bind-... cases work at runtime but were missing coverage for the editor. I took the most relevant set of the tests for running bind-... code and added them to the tests for codegen.
The issue here is that we were missing tests for the design time code path. We have tests that the bind-... cases work at runtime but were missing coverage for the editor. I took the most relevant set of the tests for running bind-... code and added them to the tests for codegen.
The issue here is that we were missing tests for the design time code path. We have tests that the bind-... cases work at runtime but were missing coverage for the editor. I took the most relevant set of the tests for running bind-... code and added them to the tests for codegen.
The issue here is that we were missing tests for the design time code path. We have tests that the bind-... cases work at runtime but were missing coverage for the editor. I took the most relevant set of the tests for running bind-... code and added them to the tests for codegen.
We've fixed the problem in the compiler. Keeping this open for now since folks with the 0.2.0 tooling will still hit it. |
@rynowak Your fix for that is bc786e0253947dea35e5984531b026d446cef3ec, right? I'm going to cherry-pick that over into a new |
Yeah, that's what I had in mind. Sounds good |
The issue here is that we were missing tests for the design time code path. We have tests that the bind-... cases work at runtime but were missing coverage for the editor. I took the most relevant set of the tests for running bind-... code and added them to the tests for codegen.
The fix for this is now published in the 0.2.1 release. How to updateYou only need to update your Visual Studio extension. In VS, go to Tools, then Extensions and Updates, then in Updates select the Visual Studio Marketplace item. It should prompt you to update the ASP.NET Core Blazor Language Services extension to version 15.7.10237 (or later, depending on when you're reading this). Update to the latest version. You don't need to update your project to the newly-released 0.2.1 package versions. You can do if you want to, but it makes no difference as they are identical to the 0.2.0 packages. The only reason we published updated 0.2.1 packages is because newly-created projects will reference 0.2.1 (our build system updates this automatically). |
The issue here is that we were missing tests for the design time code path. We have tests that the bind-... cases work at runtime but were missing coverage for the editor. I took the most relevant set of the tests for running bind-... code and added them to the tests for codegen.
I had VS crashes after updating Blazor extension
The text was updated successfully, but these errors were encountered: