This repository has been archived by the owner on Feb 25, 2021. It is now read-only.
Upgrade Mono binaries for Preview 8 #1834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rynowak
reviewed
Jul 22, 2019
| "framework": { | ||
| "name": "Microsoft.NETCore.App", | ||
| "version": "3.0.0-alpha" | ||
| "version": "2.0.0" |
There was a problem hiding this comment.
Do you know the reason who this isn't pointing in 3.0 anymore? IIRC in the past this was needed to work for users that didn't have a 2.0 runtime installed. Has something changed here?
There was a problem hiding this comment.
Has something changed here?
For a while we've had this super risk-averse technique of specifying "version": "3.0.0-alpha", but it doesn't really make sense given that this file also specifies "rollForwardOnNoCandidateFx": 2 (that was added after we previously reported the issues with running it on machines with only .NET Core 3.0 previews).
I think by now we can trust that "rollForwardOnNoCandidateFx": 2 will do its job properly in the current 3.0 preview SDKs.
rynowak
approved these changes
Jul 22, 2019
ghost
deleted the
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.