Skip to content
This repository has been archived by the owner on Feb 25, 2021. It is now read-only.

Add support for binding long / float / double / decimal #926

Merged
merged 1 commit into from
Jun 5, 2018

Conversation

Suchiman
Copy link
Contributor

@Suchiman Suchiman commented Jun 4, 2018

Based on #630 this adds support for binding float, double and decimal as well as long.
Changes were re-done on dev to solve merge conflicts and related testcases added (hope this is in time for 0.4 @SteveSandersonMS 😀)

@SteveSandersonMS SteveSandersonMS merged commit 43eecf5 into dotnet:dev Jun 5, 2018
@SteveSandersonMS
Copy link
Member

Thanks @Suchiman! Your PRs are always so tidy and complete - perfect!

@Andrzej-W
Copy link

@Suchiman You have made a great job in #926. What do you think about binding to nullable types? When value of nullable numeric type is null input box should be empty. Conversion from empty input box to nullable numeric type should produce null instead of 0. I think it is a good idea, but I cannot do it myself - I have no experience with all those tools used to build Blazor.

@Daddoon
Copy link
Contributor

Daddoon commented Jun 16, 2018

I actually made it previously but i don't have commited anything else since @Suchiman has commited something here.

PR #1012 has been submitted yesterday from @vertonghenb , also based on my PR #630 , and that cover your need Andrzej-W .

I think you just have to wait now @Andrzej-W !

Thanks everyone !

EDIT: Actually i am wrong , #1012 only cover nullable bool (bool?).

#630 actually implement nullable float/double/decimal/int (not long) if i'm not wrong, but i didn't implementend any test in the test project (there was not commited if i remember).

I may take a look about it, but i think i will not be able to see it since Tuesday.

@vertonghenb
Copy link
Contributor

vertonghenb commented Jun 16, 2018

@Daddoon Correct, currently only for "bool?". if we agree that null is allowed (see answer from @SteveSandersonMS ), i'll take on the others as well. The PR is just a starting point for now see #1007

@Daddoon
Copy link
Contributor

Daddoon commented Jun 16, 2018

Thanks @vertonghenb , i didn't see your post, thanks for the info!

@Andrzej-W
Copy link

@Daddoon I'm sorry, I have forgotten that this PR is based on your work.

@Daddoon
Copy link
Contributor

Daddoon commented Jun 16, 2018

Where is the problem @Andrzej-W ?
We are all here for collaborating, there is no problem. ;)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants