Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SDK #542

Merged
merged 1 commit into from
Jan 5, 2018
Merged

Update SDK #542

merged 1 commit into from
Jan 5, 2018

Conversation

pakrym
Copy link
Contributor

@pakrym pakrym commented Jan 5, 2018

No description provided.

@pakrym pakrym merged commit a990a1e into dev Jan 5, 2018
@natemcmaster
Copy link
Contributor

As expected, this lifted nuget to a version that has this bug in it: NuGet/Home#6351. Looks like we need to update https://github.com/aspnet/Scaffolding/tree/dev/src/VS.Web.CG.Tools to workaround it

@natemcmaster natemcmaster deleted the pakrym/update-sdk branch January 5, 2018 18:38
@pakrym
Copy link
Contributor Author

pakrym commented Jan 5, 2018

What impact would disabling package verifier rule until the nuget bug is fixed cause? Would the absence of this file break things?

@natemcmaster
Copy link
Contributor

The CLI tool wouldn't work as expected. This is a valid failure that we should fix. Rohit seemed to think this should be as simple as updating the PackagePath setting in our csproj file

@rohit21agrawal
Copy link

yes, please see the workaround here:
NuGet/Home#6351 (comment)

@pakrym
Copy link
Contributor Author

pakrym commented Jan 5, 2018

dotnet/Scaffolding#670

@natemcmaster
Copy link
Contributor

I think @muratg is also going to write a script to scan our nupkgs for any other extensionless files. I can't think of any others off the top of my head. I think dotnet-ef uses nuspec directly, so they shouldn't be affected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants