React to SignalR changes #154
Conversation
|
cc @anurse |
| @@ -173,6 +171,7 @@ Microsoft.Extensions.TaskCache.Sources,noship,exclude | |||
| Microsoft.Extensions.TypeNameHelper.Sources,noship,exclude | |||
| Microsoft.Extensions.WebEncoders,ship,include | |||
| Microsoft.Extensions.WebEncoders.Sources,noship,exclude | |||
| Microsoft.Extensions.WebSockets.Internal,noship,exclude | |||
There was a problem hiding this comment.
Why is this package listed twice?
There was a problem hiding this comment.
It's a package with .Internal. We really shouldn't be publishing it to nuget.org
There was a problem hiding this comment.
We have another .Internal package that ships I believe. I'd like @anurse to comment because he knows the latest on this.
There was a problem hiding this comment.
It needs to ship along with SignalR, so it needs to be 'ship'. It's .Internal to indicate that it is not currently supported on it's own. It's only "supported" via using SignalR.
There was a problem hiding this comment.
By ship, we mean publish to nuget.org when 1.2.0 comes out. Does that sound right? If so, can we come up with a better name for this or make it a .Sources package?
There was a problem hiding this comment.
Yeah, publish at 1.2.0. The big reason for the name is that we are already shipping a Microsoft.Extensions.WebSockets, so we'll have to merge the two when we actually come to ship it. I guess we could make it a sources package, or just pull the source in and not ship the package if @davidfowl 's cool with that.
There was a problem hiding this comment.
Filed aspnet/SignalR#24 to track a better Id for those packages and \ or an alternate solution. I'll leave them as noship for now
|
bump. Need to get this in to unblock dev |
| Microsoft.AspNetCore.Server.IISIntegration,ship,include | ||
| Microsoft.AspNetCore.Server.IntegrationTesting,noship,exclude | ||
| Microsoft.AspNetCore.Server.Kestrel,ship,include | ||
| Microsoft.AspNetCore.Server.Kestrel.Https,ship,include | ||
| Microsoft.AspNetCore.Server.WebListener,ship,include | ||
| Microsoft.AspNetCore.Session,ship,include | ||
| Microsoft.AspNetCore.SignalR.Messaging,noship,exclude | ||
| Microsoft.AspNetCore.SignalR.Redis,noship,exclude |
| @@ -77,22 +77,20 @@ Microsoft.AspNetCore.Rewrite,ship,include | |||
| Microsoft.AspNetCore.Routing,ship,include | |||
| Microsoft.AspNetCore.Routing.Abstractions,ship,include | |||
| Microsoft.AspNetCore.Routing.DecisionTree.Sources,noship,exclude | |||
| Microsoft.AspNetCore.Sockets,noship,exclude | |||
pranavkm
force-pushed
the
prkrishn/signalr
branch
from
016628b
to
b39f07a
Compare
|
🆙 :date |
| Microsoft.AspNetCore.StaticFiles,ship,include | ||
| Microsoft.AspNetCore.TestHost,ship,exclude | ||
| Microsoft.AspNetCore.Testing,noship,exclude | ||
| Microsoft.AspNetCore.WebSockets,ship,include | ||
| Microsoft.AspNetCore.WebSockets.Internal,noship,exclude |
There was a problem hiding this comment.
I thought we were planning on renaming these first: aspnet/SignalR#24
There was a problem hiding this comment.
Does this affect anything right now? If not that's fine.
There was a problem hiding this comment.
Nope. Just makes sure we don't ignore the work item :)
cc @muratg \ @anurse