Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove uses of TaskCache.CompletedTask #238

Closed
Tratcher opened this issue Jun 7, 2017 · 0 comments
Closed

Remove uses of TaskCache.CompletedTask #238

Tratcher opened this issue Jun 7, 2017 · 0 comments

Comments

@Tratcher
Copy link
Member

Tratcher commented Jun 7, 2017

Now that we target netstandard2.0 / net461 we have access to Task.CompletedTask. Remove uses of TaskCache.CompletedTask.

We may be able to remove references to Microsoft.Extensions.TaskCache.Sources in the process.
@Tratcher Tratcher added the task label Jun 7, 2017
@JunTaoLuo JunTaoLuo mentioned this issue Jun 8, 2017
Merged
motowilliams added a commit to motowilliams/Docs that referenced this issue Sep 19, 2017
@motowilliams
Updates TaskCache to Task
9a43edd 
Since [TaskCache](dotnet/extensions#238) was removed this updates the samples to use `Task.CompletedTask` instead
This was referenced Sep 19, 2017
Closed
Merged
Rick-Anderson added a commit to dotnet/AspNetCore.Docs that referenced this issue Sep 27, 2017
@Rick-Anderson
Update live with current master (#4426)
96ce03d 
* Add PO localization doc

* More edits

* Updates TaskCache to Task

Since [TaskCache](dotnet/extensions#238) was removed this updates the samples to use `Task.CompletedTask` instead

* More edits

* More edits

* Change code snippet type from C# to CSHTML

* Add missing snippet types

* React to feedback

* Add support disclaimer

* UE pass on Publishing to IIS topic

* Drop literal_block comments and fix a few code blocks

* Fix demo code for AddAuthentication.AddCookie

In .Net Core 2.0 using the code as supplied results in an exception, the fix is to pass the scheme name when calling AddCookie.

Fails:
services.AddAuthentication("MyCookieAuthenticationScheme")
        .AddCookie

Works:
Fix demo code for services.AddAuthentication.AddCookie
services.AddAuthentication("MyCookieAuthenticationScheme")
        .AddCookie("MyCookieAuthenticationScheme",

* React to feedback

* Fix one

* Convert title to sentence case

* Add missing param to AddCookie call

* React to feedback
Rick-Anderson added a commit to dotnet/AspNetCore.Docs that referenced this issue Sep 29, 2017
@Rick-Anderson
Update live with current master (#4454)
b330159 
* Add PO localization doc

* More edits

* Updates TaskCache to Task

Since [TaskCache](dotnet/extensions#238) was removed this updates the samples to use `Task.CompletedTask` instead

* More edits

* More edits

* Change code snippet type from C# to CSHTML

* Add missing snippet types

* Add Required note to model validation topic

Fixes #1928

* MVC views overview update

Updates

Updates

Updates

Updates

Update

* React to feedback

* React to feedback

* Add support disclaimer

* UE pass on Publishing to IIS topic

* React to feedback

Minor update

* Move VS Tools for Docker doc to ASP.NET Core repo

* React to feedback

* React to feedback

* Drop literal_block comments and fix a few code blocks

* Fix demo code for AddAuthentication.AddCookie

In .Net Core 2.0 using the code as supplied results in an exception, the fix is to pass the scheme name when calling AddCookie.

Fails:
services.AddAuthentication("MyCookieAuthenticationScheme")
        .AddCookie

Works:
Fix demo code for services.AddAuthentication.AddCookie
services.AddAuthentication("MyCookieAuthenticationScheme")
        .AddCookie("MyCookieAuthenticationScheme",

* React to feedback

* Fix one

* React to feedback

* Convert title to sentence case

* Add missing param to AddCookie call

* React to feedback

* React to feedback

* Add RP tutorial step 'Uploading files' to TOC

* fix breadcrumb link to core

* Update model-binding.md

Fixing type `CancelationToken` -> `CancellationToken`

* minor clean up (#4431)

* Updates

* Fix a link

* Explain post delete method

Update

* Fix inadvertent uid change (typo)

* React to feedback

* React to feedback

* React to feedback

* Alter app cookie configuration code samples

* Update first-web-api-mac.md (#4441)

* Update web-api-vsc.md

* Remove dead project file (#4427)

* Updates to the intro: layouts, partials, VCs

* Update web-publishing-vs.md (#4447)

* Update web-publishing-vs.md

* Update web-publishing-vs.md

* Update identity-enable-qrcodes.md

* Update identity-enable-qrcodes.md

* Update identity-enable-qrcodes.md

* Remove extra space

* Minor edits

* Add TOC link to snapshot debugging doc

* Update index.md (#4443)

* Update index.md

* Update index.md
natemcmaster pushed a commit that referenced this issue Nov 5, 2018
@pranavkm
Modify PollingWildCardChangeToken to include the timestamp of the files
9d60f64 
Fixes #238
natemcmaster pushed a commit that referenced this issue Nov 6, 2018
@jdom @HaoK
Options builder to chain Configure calls of the same named TOptions (#…
fe3f1b1 
…238)
@ghost ghost locked as resolved and limited conversation to collaborators Dec 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Tratcher