Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dead project file #4427

Merged
merged 1 commit into from
Sep 28, 2017
Merged

Remove dead project file #4427

merged 1 commit into from
Sep 28, 2017

Conversation

guardrex
Copy link
Collaborator

Fixes #4085

The topic uses the project file at first-mvc-app-xplat, so it looks like the sample at tutorials/first-mvc-app-mac/start-mvc/sample can be removed, which isn't really a sample anyway ... it's just a project file.

@dnfclas
Copy link

dnfclas commented Sep 27, 2017

@guardrex,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

@guardrex
Copy link
Collaborator Author

guardrex commented Sep 27, 2017

sry ... didn't spot that you self-assigned. I'm looking for things I can knock out on our way to <=220 issues. .... What do they say there? ... "Just do it and ask for forgiveness 🙏 later??" lol

@scottaddie
Copy link
Member

@Rick-Anderson Please review.

@Rick-Anderson Rick-Anderson merged commit 8b5733f into dotnet:master Sep 28, 2017
@guardrex guardrex deleted the guardrex/first-mvc-app-mac-samp-update branch September 28, 2017 18:58
Rick-Anderson added a commit that referenced this pull request Sep 29, 2017
* Add PO localization doc

* More edits

* Updates TaskCache to Task

Since [TaskCache](dotnet/extensions#238) was removed this updates the samples to use `Task.CompletedTask` instead

* More edits

* More edits

* Change code snippet type from C# to CSHTML

* Add missing snippet types

* Add Required note to model validation topic

Fixes #1928

* MVC views overview update

Updates

Updates

Updates

Updates

Update

* React to feedback

* React to feedback

* Add support disclaimer

* UE pass on Publishing to IIS topic

* React to feedback

Minor update

* Move VS Tools for Docker doc to ASP.NET Core repo

* React to feedback

* React to feedback

* Drop literal_block comments and fix a few code blocks

* Fix demo code for AddAuthentication.AddCookie

In .Net Core 2.0 using the code as supplied results in an exception, the fix is to pass the scheme name when calling AddCookie.

Fails:
services.AddAuthentication("MyCookieAuthenticationScheme")
        .AddCookie

Works:
Fix demo code for services.AddAuthentication.AddCookie
services.AddAuthentication("MyCookieAuthenticationScheme")
        .AddCookie("MyCookieAuthenticationScheme",

* React to feedback

* Fix one

* React to feedback

* Convert title to sentence case

* Add missing param to AddCookie call

* React to feedback

* React to feedback

* Add RP tutorial step 'Uploading files' to TOC

* fix breadcrumb link to core

* Update model-binding.md

Fixing type `CancelationToken` -> `CancellationToken`

* minor clean up (#4431)

* Updates

* Fix a link

* Explain post delete method

Update

* Fix inadvertent uid change (typo)

* React to feedback

* React to feedback

* React to feedback

* Alter app cookie configuration code samples

* Update first-web-api-mac.md (#4441)

* Update web-api-vsc.md

* Remove dead project file (#4427)

* Updates to the intro: layouts, partials, VCs

* Update web-publishing-vs.md (#4447)

* Update web-publishing-vs.md

* Update web-publishing-vs.md

* Update identity-enable-qrcodes.md

* Update identity-enable-qrcodes.md

* Update identity-enable-qrcodes.md

* Remove extra space

* Minor edits

* Add TOC link to snapshot debugging doc

* Update index.md (#4443)

* Update index.md

* Update index.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants