This repository has been archived by the owner on Dec 18, 2018. It is now read-only.
Fix issue with Binder on objects with indexers #272
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| var builder = new ConfigurationBuilder(); | ||
| var config = builder.Build(); | ||
| var options = ConfigurationBinder.Bind<List<string>>(config); |
There was a problem hiding this comment.
I don't see any asserts for this test. We should be verifying something right?
There was a problem hiding this comment.
This used to throw before the fix, so I don't typically use Assert.NotThrow... but that's basically what it this test is
|
|
| @@ -157,6 +157,14 @@ public void ConsistentExceptionOnFailedBinding(Type type) | |||
| } | |||
|
|
|||
| [Fact] | |||
| public void BinderDoesNotChokeOnIndexer() | |||
There was a problem hiding this comment.
Or better, BinderIgnoresIndexerProperties.
|
But other than that, yeah, |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #253
cc @kirthik @divega