-
Notifications
You must be signed in to change notification settings - Fork 224
Internalize JSON.NET dependency #30
Comments
Just talked to @Eilon and we might want to use |
Ummmmmmmmmmmmmm. |
No ummmmmmmmmming just yet! Specifically, we should consider using DataContractJsonSerializer, if it supports what we need. I don't think it's in CoreCLR yet, but it will be (according to what I've heard). But if it doesn't support what we want (e.g. comments), then we're off to the races. |
That serializer is terrible 😄 |
Just copy and paste JsonReader + JsonTextReader out of Json.NET, then write some code to load the JSON into a simple Dictionary/List/value object model. Example of loading JSON into a simple object model using JsonReader: https://github.com/JamesNK/Newtonsoft.Json/blob/bcd6982419c6165ed2c606eb9994c1aa6bce3735/Src/Newtonsoft.Json/Converters/ExpandoObjectConverter.cs#L62-L138 |
Fixed in f0a852a |
Today we're using JSON.NET as a package and that's no good for apps and frameworks that use this framework. This is part of the work #29
The text was updated successfully, but these errors were encountered: