Skip to content
This repository has been archived by the owner on Dec 8, 2018. It is now read-only.

Fix diagnostics packages dependencies #257

Closed
Eilon opened this issue Mar 11, 2016 · 1 comment
Closed

Fix diagnostics packages dependencies #257

Eilon opened this issue Mar 11, 2016 · 1 comment
Assignees
Milestone

Comments

@Eilon
Copy link
Member

Eilon commented Mar 11, 2016

Both the EF database error middleware and the ELM middleware depend on the concrete Diagnostics package. They should instead depend on various abstraction packages because there is no actual relationship between these various packages.

@Eilon Eilon added this to the 1.0.0-rc2 milestone Mar 11, 2016
@Eilon Eilon self-assigned this Mar 11, 2016
Eilon added a commit that referenced this issue Mar 11, 2016
Removed some extraneous dependencies and instead made all the
diagnostics packages be independent packages that happen to share some
concepts/source code.

The common Razor base class code was moved to a shared source file. Then
the Diagnostics page, ELM page, and EF database page all use that. Also
updated the page generator to use the new shared code.

See #257
Eilon added a commit that referenced this issue Mar 16, 2016
Removed some extraneous dependencies and instead made all the
diagnostics packages be independent packages that happen to share some
concepts/source code.

The common Razor base class code was moved to a shared source file. Then
the Diagnostics page, ELM page, and EF database page all use that. Also
updated the page generator to use the new shared code.

See #257
@Eilon
Copy link
Member Author

Eilon commented Mar 16, 2016

0f74187

@Eilon Eilon closed this as completed Mar 16, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant