Skip to content
This repository has been archived by the owner on Dec 8, 2018. It is now read-only.

It is not possible to copy text to clipboard from error message on development page. #319

Closed
ghost opened this issue Jul 20, 2016 · 9 comments
Closed

It is not possible to copy text to clipboard from error message on development page. #319

ghost opened this issue Jul 20, 2016 · 9 comments
Assignees
@kichalla
Labels
3 - Done bug
Milestone
1.1.0-preview1

Comments

@ghost
Copy link

ghost commented Jul 20, 2016

From @maxim-boligatov on July 20, 2016 7:51

When exception occurs development page is displayed in browser.
Sometimes it significantly increases productivity when it is possible to copy error text or sample message from error page.
For example for the following example I can just find RenderSection line in source:

         <!-- Styles -->
         @this.RenderSection("styles", required: false)
        </head>
        <body>
            @RenderBody()
        </body>
        </html>

But due to interactivity added to development page (all mouse events are handled) I cannot copy text to clipboard easy. So I have to extract it from HTML using firebug...
How can it be fixed/improved? What do you think?

Copied from original issue: aspnet/Mvc#5048
@ghost
Copy link
Author

ghost commented Jul 20, 2016

From @pranavkm on July 20, 2016 13:46

Could you file this bug in the Diagnostics repo?

@Eilon
Copy link
Member

Eilon commented Jul 20, 2016

I thought at the bottom of the Diagnostics page there's a "Show raw details" link that makes it easy to copy & paste?

@Eilon
Copy link
Member

Eilon commented Jul 20, 2016

Indeed, at the bottom of the developer exception page there's a "Show raw exception details" link that shows the plaintext exception message and stack trace.

If you click that link, you get text that's easy to copy and paste:

raw-exception-details

@Eilon Eilon closed this as completed Jul 20, 2016
@Eilon Eilon added the invalid label Jul 20, 2016
@pranavkm
Copy link
Contributor

I thought @maxim-boligatov was referring to the actual source code (i.e. the code from the cs \ cshtml file) rather than the stack trace?

@Eilon
Copy link
Member

Eilon commented Jul 20, 2016

Oh the source code being copyable? I'm not sure why you'd want to copy the source code... it's clearly not good source code if it threw an exception 😄

@ghost
Copy link
Author

ghost commented Jul 20, 2016

It is good explained above.. a search of copied string it is the fastest way to find the line which was a reason of an error (we cannot click on error and open VS with related source code... at least for now and without browser plugins).
I think you agree that each error message will sound like "This specific feature is failed during this specific action". In case of localized resources it will be still some unique piece of source code. So I just need to search it in solution... Analyzing of stack trace will be much more slower to identify code location.

In other words due to new interactivity "features" exception page does not allow text copying.
And this interactivity is really strange decision... Do you need more space for information? Put it into 2 columns... No professional developer works on monitor with resolution less than FullHD...
I hope in the future MS will not come to the market with Visual Studio Nokia 3310 Edition...
Let's avoid unnecessary clicks... like Show raw bla-bla... scrolling is faster... much faster from point of view of usability...

@ghost
Copy link
Author

ghost commented Jul 21, 2016

Why is it closed?

@Eilon Eilon reopened this Jul 21, 2016
@Eilon Eilon added this to the 1.1.0 milestone Jul 21, 2016
@Eilon
Copy link
Member

Eilon commented Jul 21, 2016 •
edited

Ok we took a further look at this and I agree that there are some usability problems on this error page.

Some things we should fix:

  1. The way that the CSS and clickability of this page are done needs improvement. Instead of entire rows being marked as "clickable" there should be a little expand/collapse button that is clickable.
  2. Get rid of the row highlight-on-hover stuff. It's irritating.
  3. Make the "Show raw exception details" link be more usable by making it look nicer, and also support expand/collapse (not just expand)

@pranavkm pranavkm mentioned this issue Jul 26, 2016
Closed
@Eilon
Copy link
Member

Eilon commented Jul 26, 2016

@kichalla this is the issue I discussed with you yesterday.

kichalla added a commit that referenced this issue Jul 27, 2016
@kichalla
[Fixes #319] It is not possible to copy text to clipboard from error …
6ffe04a 
…message on development page.
kichalla added a commit that referenced this issue Jul 27, 2016
@kichalla
[Fixes #319] It is not possible to copy text to clipboard from error …
117b9ed 
…message on development page.
kichalla added a commit that referenced this issue Jul 28, 2016
@kichalla
[Fixes #319] It is not possible to copy text to clipboard from error …
f2d71ff 
…message on development page.
kichalla added a commit that referenced this issue Jul 28, 2016
@kichalla
[Fixes #319] It is not possible to copy text to clipboard from error …
b4044c9 
…message on development page.
@kichalla kichalla added 3 - Done and removed bug labels Jul 29, 2016
@Eilon Eilon added bug and removed 2 - Working labels Jul 29, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kichalla kichalla

Labels
3 - Done bug
Projects
None yet
Milestone
1.1.0-preview1
Development

No branches or pull requests
3 participants
@pranavkm @Eilon @kichalla