Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link to partial tag helper? #7322

Closed
kylejrp opened this issue Jun 27, 2018 — with docs.microsoft.com · 1 comment
Closed

Link to partial tag helper? #7322

kylejrp opened this issue Jun 27, 2018 — with docs.microsoft.com · 1 comment
Assignees
@scottaddie
Labels
Pri1 High priority, do before Pri2 and Pri3 Source - Docs.ms Docs Customer feedback via GitHub Issue
Projects
Sprint 138 (July 2 - July 20) Board View
Milestone
Sprint 138 (July ...

Comments

@kylejrp docs.microsoft.com
Copy link

kylejrp commented Jun 27, 2018

Would it be useful to link to the partial tag helper here?
https://docs.microsoft.com/en-us/aspnet/core/mvc/views/tag-helpers/built-in/partial-tag-helper?view=aspnetcore-2.1

Document Details

⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.
@scottaddie scottaddie self-assigned this Jun 27, 2018
@scottaddie scottaddie added the Source - Docs.ms Docs Customer feedback via GitHub Issue label Jun 27, 2018
@scottaddie
Copy link
Member

scottaddie commented Jun 27, 2018 •
edited

@kylejrp I think that's a great idea. In its current state, the doc makes it seem as though HTML Helpers are the only option for rendering a partial view. The Partial Tag Helper is a valid alternative in ASP.NET Core 2.1+.

@scottaddie scottaddie added the Pri1 High priority, do before Pri2 and Pri3 label Jun 27, 2018
@scottaddie scottaddie moved this from Next up to In progress in Sprint 138 (July 2 - July 20) Board View Jul 2, 2018
@scottaddie scottaddie mentioned this issue Jul 2, 2018
Merged
Sprint 138 (July 2 - July 20) Board View automation moved this from In progress to Done Jul 3, 2018
scottaddie added a commit that referenced this issue Jul 3, 2018
@scottaddie
UE pass on Partial views doc (#7417)
9121516 
Fixes #7322 

**Changes**
- Add Partial Tag Helper info (2.1+ only)
- Simplify & improve sample app and update to 2.1
- Add **Additional resources** section
- Apply Acrolinx suggestions
- Introduce headings in **Reference a partial view** section

[Internal Review Page](https://review.docs.microsoft.com/en-us/aspnet/core/mvc/views/partial?branch=pr-en-us-7417&view=aspnetcore-2.1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scottaddie scottaddie

Labels
Pri1 High priority, do before Pri2 and Pri3 Source - Docs.ms Docs Customer feedback via GitHub Issue
Projects
No open projects
Sprint 138 (July 2 - July 20) Board View
  
Done
Milestone
Sprint 138 (July 2 - July 20)
Development

No branches or pull requests
2 participants
@kylejrp @scottaddie