Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UE pass on Partial views doc #7417

Merged
merged 8 commits into from
Jul 3, 2018
Merged

Conversation

scottaddie
Copy link
Member

@scottaddie scottaddie commented Jul 2, 2018

Fixes #7322

Changes

  • Add Partial Tag Helper info (2.1+ only)
  • Simplify & improve sample app and update to 2.1
  • Add Additional resources section
  • Apply Acrolinx suggestions
  • Introduce headings in Reference a partial view section

Internal Review Page


By [Steve Smith](https://ardalis.com/), [Maher JENDOUBI](https://twitter.com/maherjend), [Rick Anderson](https://twitter.com/RickAndMSFT), and [Scott Sauber](https://twitter.com/scottsauber)

ASP.NET Core MVC supports partial views, which are useful when you have reusable parts of web pages you want to share between different views.
ASP.NET Core MVC supports partial views, which are useful for sharing reusable parts of web pages across different views.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding --
For example, the default templates for a new web app with individual user accounts creates the following partials:

  • _LoginPartial.cshtml: Called in _Layout.cshtml.
  • _CookieConsentPartial: Called in _Layout.cshtml.
  • _ValidationScriptsPartial.cshtml: ...


### Partial view discovery

When referencing a partial view, you can refer to its location in several ways. For example:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feature the partial tag helper
<partial name="_CookieConsentPartial" />

We need to show that and that's it's the preferred approach.

@scottaddie scottaddie changed the title UE pass on Partial views doc [WIP] UE pass on Partial views doc Jul 3, 2018
@scottaddie scottaddie changed the title [WIP] UE pass on Partial views doc UE pass on Partial views doc Jul 3, 2018
@scottaddie
Copy link
Member Author

@Rick-Anderson Please take another look.

Copy link
Contributor

@Rick-Anderson Rick-Anderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@Rick-Anderson
Copy link
Contributor

@scottaddie can you merge this then merge the live PR?

@scottaddie scottaddie merged commit 9121516 into master Jul 3, 2018
@scottaddie scottaddie deleted the scottaddie/partial-th-option branch July 3, 2018 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants