CI Update #5878
CI Update #5878
Conversation
|
@cillroy changes look good to me. Let me know when I can merge this. |
This reverts commit 1832723.
* Update azure-apps-preview-notice.md (#5857) * Link to .NET Core CLI publish command doc (#5864) * Link to .NET Core CLI publish command doc * Verbiage tweak * fix typo (#5866) * Update intro.md (#5869) `classnameID` (where `classname` is the name of the class, such as `Student`) as the primary key. In `classnameID`, `classname` is the name of the class, such as `Student` in * Update view-components.md (#5872) altering range of code displayed to remove hanging closing } and closing table tag * C13511: Spaces should be replaced to avoid localization problems (#5871) Hello, @Rick-Anderson, Localization team has reported source content issue that causes localized version to have broken format compared to en-us version. Please, help to check my proposed file change into the article and help to merge if you agree with fix. If not, please, let me know either if you would like me to fix it in another way within this PR, if you prefer to fix it in another PR or if I should close this PR as by-design. In case of using another PR, please, let me know of your PR number, so we can confirm and close this PR. Many thanks in advance. * CI Update (#5878) * Recommended language change (#5883) * Updated with NET Core SDK 2.0 commands (#5886) * Updated with NET Core SDK 2.0 commands * Quick UE pass * Prevent javascript injection. (#5885) * Troubleshoot SDK warnings (#5880) * WIP Troubleshoot SDK warnings * Work * work * Address Gauntlet warning in ms.date value * Adjust H2 title casing and spacing * Quick UE pass * Update Configuration doc to use double underscores instead of colons for hierarchical config keys (4968) (#5876) * changes to configuration doc * fixes for scott * change for Dan * Update index.md * Code fence double underscore and add missing period * Eliminate unnecessary sentence * Missing npm task runner extension (#5893) * Revert "Missing npm task runner extension (#5893)" (#5894) This reverts commit a90faeb. * Note about task runner explorer option (#5895) * Note about task runner explorer option The gulp file has to be in the root directory or in the directory with package.json not in any subdirectory. * verbiage tweaks * added anchored link (#5896)
|
@Rick-Anderson @scottaddie @rachelappel This PR converted the ends of tab markup from ... to I've been converting following this PR because I thought this was a new direction (and didn't ask 😢). I can switch back; but since this PR introduced a lot of I also think this was the PR that changed the tab hashes to four ( Are we good on that approach going forward? ... four hashes? |
|
Here's how to determine the appropriate number of hashes for tabs: number of hashes = 1 + number of hashes used by parent heading |
|
Yeah, what should we do with the "* * *" - I noticed the dashes were magically converted to *'s on a couple of docs. I was changing them back. Thought it was just crap that got caught in there. |
That isn't being followed AFAIK by anyone here or on .NET docs. Here's a set of @mairaw changes (When you're doing something Maira, I consider that the GOLD STANDARD 🥇 in docs!) ... here's a set of changes where the tabs are being set they way they were originally explained to me ... https://github.com/dotnet/docs/pull/4935/files See line 82 ... ... under a 3rd level heading (line 66) ... The training I received was one hash regardless of other headings. If that changed, 👍 gotcha; but it doesn't look like anyone knows. |
|
That's the training I received as well. Markdownlint says it's invalid. The issue is corrected when sticking with my suggested strategy. |
|
I noticed |
Aren't tabs a proprietary MS markdown feature? If so, I'd be surprised if Markdownlint is the source of truth for their implementation. |
|
Tabs are a custom Markdown extension. Since Markdownlint is bundled in the Docs Authoring Pack provided to external contributors, we should cleanup those warnings to set the precedent. |
Fixes #5879