Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve environment variable coverage #7092

Merged
merged 1 commit into from
Jun 19, 2018
Merged

Improve environment variable coverage #7092

merged 1 commit into from
Jun 19, 2018

Conversation

guardrex
Copy link
Collaborator

Fixes #6760

The goals are ...

  • Surface that env vars aren't added by default with the Generic Host.
  • Describe AddEnvironmentVariables.
  • Deal with env var prefix issue.
  • Explain how to set env vars for dev (shoot reader to Multiple environments topic for more info). Mention VS, command-line, and VSC config.
  • Add VSC example to the Multiple environments topic.
  • Update the sample app and snippets for the topic.

@guardrex guardrex requested a review from Tratcher June 16, 2018 14:17
@guardrex guardrex mentioned this pull request Jun 17, 2018
Closed
8 tasks
@guardrex guardrex requested a review from scottaddie June 18, 2018 23:27
@guardrex guardrex mentioned this pull request Jun 19, 2018
Closed
@scottaddie scottaddie merged commit 3ef776e into master Jun 19, 2018
@scottaddie scottaddie deleted the guardrex/generic-host-update2 branch June 19, 2018 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tratcher Tratcher Tratcher approved these changes

@scottaddie scottaddie scottaddie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Address inconsistencies in env var prefixes
3 participants
@guardrex @Tratcher @scottaddie