Minor usability improvements to dotnet-user-secrets #173
Conversation
|
Hi @natemcmaster, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! The agreement was validated by .NET Foundation and real humans are currently evaluating your PR. TTYL, DNFBOT; |
|
cc @mikaelm12 for review |
|
|
||
| var ex = Assert.Throws<GracefulException>(() => secretManager.RunInternal("list", "--project", projectPath)); | ||
|
|
||
| Assert.Equal(ex.Message, Resources.FormatError_ProjectPath_NotFound(projectPath)); |
There was a problem hiding this comment.
Nit: Shouldn't the order of these arguments be expected then actual
There was a problem hiding this comment.
Good catch. Yes, it is the other way around.
| @@ -35,7 +77,7 @@ public void SetSecrets(bool fromCurrentDirectory) | |||
| new KeyValuePair<string, string>("key2", string.Empty) | |||
| }; | |||
|
|
|||
| var projectPath = UserSecretHelper.GetTempSecretProject(); | |||
| var projectPath = GetTempSecretProject(); | |||
|
|
|||
There was a problem hiding this comment.
Can you clarify...do you mean I should add a space?
There was a problem hiding this comment.
Sorry, I meant is the empty line 81 nedded
There was a problem hiding this comment.
No, can be removed.
|
🚢 it |
natemcmaster
force-pushed
the
namc/fit-n-finish
branch
from
f99dede
to
11bbd6d
Compare
Resolves #170.
Resolves #171.
cc @dougbu