Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design: Public API to instantiate DbContext classes #7050

Closed
bricelam opened this issue Nov 18, 2016 · 7 comments
Closed

Design: Public API to instantiate DbContext classes #7050

bricelam opened this issue Nov 18, 2016 · 7 comments
Assignees
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone

Comments

@bricelam
Copy link
Contributor

bricelam commented Nov 18, 2016

Scaffolding is now using DbContextOperations.CreateContext() to instantiate contexts at design-time; however, this is an internal API.

Model visualization may require the same functionality.

We should consider adding public API with this functionality.

cc @prafullbhosale

@bricelam
Copy link
Contributor Author

If we do, we should add it to 1.0.3 as well.

@divega divega added this to the 1.2.0 milestone Nov 18, 2016
@ajcvickers ajcvickers modified the milestones: 2.0.0-preview1, 2.0.0 Apr 19, 2017
@bricelam
Copy link
Contributor Author

bricelam commented Apr 27, 2017

@Eilon @ajcvickers Do we want to try and get this into 2.0.0-preview1 too? The work for Program.BuildWebHost (#8164) has broken the internal APIs Scaffolding was using...

@bricelam
Copy link
Contributor Author

bricelam commented Apr 27, 2017

(and possibly 1.0.4 & 1.1.2 so Scaffolding doesn't have to condition it on version)

@ajcvickers
Copy link
Member

@bricelam Without this, what is broken? When you say "Scaffolding" I'm not sure which "Scaffolding" that is--reverse engineering, or asp.net scaffolding?

Why would we put it in 1.0.4/1.1.2? What is broken there that this would fix?

@bricelam
Copy link
Contributor Author

bricelam commented Apr 27, 2017

The Scaffoding repo. Anything they use a DbContext for is broken.

⭐️ I'll add back an overload to maintain compatibility in 2.0.0-preview1. ⭐️

@ajcvickers
Copy link
Member

@bricelam What's the priority of this for 2.0?

@bricelam
Copy link
Contributor Author

We should do it so Scaffolding doesn't have to rely on internal API. Shouldn't be much work.

@bricelam bricelam added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jun 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Development

No branches or pull requests

3 participants