Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use strongly typed ReadValue when reading values into shadow state #738

Closed
ajcvickers opened this issue Oct 1, 2014 · 2 comments
Closed

Use strongly typed ReadValue when reading values into shadow state #738

ajcvickers opened this issue Oct 1, 2014 · 2 comments
Assignees
@ajcvickers
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Milestone
1.0.0

Comments

@ajcvickers
Copy link
Member

Similar to issue #736, when reading values from an IValueReader into shadow state we always use ReadValue<object>, which translates to reading a value for object from the DbDataReader. We know that using the typed reader method can be important for some ADO.NET providers that do dynamic conversion based on the expected type.
@ajcvickers ajcvickers mentioned this issue Oct 2, 2014
Closed
@rowanmiller rowanmiller added this to the 1.0.0-rc1 milestone Oct 8, 2014
@ajcvickers ajcvickers mentioned this issue Nov 17, 2014
Closed
@rowanmiller rowanmiller modified the milestones: 7.0.0-rc1, 7.0.0 Nov 25, 2014
@rowanmiller rowanmiller modified the milestones: Backlog, 7.0.0 Dec 12, 2014
@rowanmiller
Copy link
Contributor

Need to address when we re-enable SQLite

@ajcvickers
Copy link
Member Author

Re-triage; important for other providers, including SQLite.

@ajcvickers ajcvickers removed this from the Backlog milestone Mar 10, 2015
@ajcvickers ajcvickers self-assigned this Mar 10, 2015
@rowanmiller rowanmiller added this to the 7.0.0 milestone Mar 11, 2015
@ajcvickers ajcvickers modified the milestones: 7.0.0-beta5, 7.0.0 May 1, 2015
@ajcvickers ajcvickers added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Oct 15, 2022
@ajcvickers ajcvickers modified the milestones: 1.0.0-beta5, 1.0.0 Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ajcvickers ajcvickers

Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
3 participants
@ajcvickers @rowanmiller @AndriySvyryd