Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make set discovery a separate service #977

Closed
AndriySvyryd opened this issue Oct 29, 2014 · 3 comments
Closed

Make set discovery a separate service #977

AndriySvyryd opened this issue Oct 29, 2014 · 3 comments
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone
2.0.0

Comments

@AndriySvyryd
Copy link
Member

Avoid coupling ModelBuilder or Model with the context.
@AndriySvyryd AndriySvyryd mentioned this issue Oct 29, 2014
Merged
@AndriySvyryd AndriySvyryd self-assigned this Oct 29, 2014
@rowanmiller rowanmiller added this to the 1.0.0-rc1 milestone Nov 5, 2014
@rowanmiller
Copy link
Contributor

We should discuss in design meeting as this one is a little controversial.

@rowanmiller rowanmiller modified the milestones: 7.0.0-rc1, 7.0.0 Nov 25, 2014
@rowanmiller rowanmiller added task and removed pri0 labels Dec 17, 2014
@rowanmiller rowanmiller modified the milestones: Backlog, 7.0.0 Dec 17, 2014
@AndriySvyryd AndriySvyryd self-assigned this Apr 1, 2016
@AndriySvyryd
Copy link
Member Author

Alternatively we could extract ModelSource.CreateModel to a different service

@smitpatel smitpatel mentioned this issue May 31, 2017
Merged
@AndriySvyryd
Copy link
Member Author

fixed in f4d74e6

@AndriySvyryd AndriySvyryd removed their assignment Jul 7, 2017
@AndriySvyryd AndriySvyryd added closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement labels Jul 7, 2017
@AndriySvyryd AndriySvyryd modified the milestones: 2.0.0, Backlog Jul 7, 2017
@AndriySvyryd AndriySvyryd changed the title Make set discovery a convention in ModelBuilder Make set discovery a separate service Jul 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
2 participants
@rowanmiller @AndriySvyryd