Fix an issue when a property is configured in multiple indexes #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…indexes using the ModelBuilder API
|
|
This was referenced Sep 7, 2018
|
@chrisblock Thanks for submitting this PR. It is essentially the same as #677, which is now merged. Both fixes look good, but #677 was slightly more DRY and therefore less code. |
|
I can't upgrade to 6.3.0 because of #1290 6.2.0 has has this problem. Seems like every version since 6.1.3 is a bust. Where's quality control, Microsoft? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should resolve #460.
Given my current understanding, the issue appears to stem from the fact that in the
IndexConfigurationclass it simply replaces the existingIndexAnnotationwith a new one (via theMetadataItem.AddAnnotationmethod), rather than appending the additionalIndexAttribute(s) to the existingIndexAnnotation(if it exists).