Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dotnet-ef from the .NET Core 3.0 SDK #14016

Closed
bricelam opened this issue Nov 26, 2018 · 9 comments

Comments

@bricelam
Copy link
Member

commented Nov 26, 2018

The EF Core runtime isn't a part of the SDK anymore. It makes sense for dotnet ef to become just a plain old global tool too on NuGet.

@bricelam

This comment has been minimized.

Copy link
Member Author

commented Nov 30, 2018

@KathleenDollard can you keep us in the loop regarding any future plans for global tools that extend dotnet?

@bricelam bricelam changed the title Consider removing dotnet-ef from the .NET Core 3.0 SDK Remove dotnet-ef from the .NET Core 3.0 SDK Nov 30, 2018

@bricelam bricelam added the blocked label Mar 15, 2019

@bricelam

This comment has been minimized.

Copy link
Member Author

commented Mar 15, 2019

Blocked on syncing with the CLI team about the future of tools.
Talking points:

  • Can templates install local tools? Do they have to be invoked using dotnet tool run ef or would dotnet ef still work?
  • Will a global tool continue to be able to extend the dotnet command? If not, should we rename our command now to avoid future breaks?

cc @wli3

@wli3

This comment has been minimized.

Copy link

commented Mar 15, 2019

Can templates install local tools? Do they have to be invoked using dotnet tool run ef or would dotnet ef still work?

Yes. You can add a tool manifest file in the template. We plan to bring back invoke by dotnet TOOLNAME https://github.com/dotnet/cli/pulls . As of today, the user need to run dotnet tool run TOOLNAME. And the user need an extra dotnet tool restore. But this is might change.

Will a global tool continue to be able to extend the dotnet command? If not, should we rename our command now to avoid future

We don't have plan to remove the extension. @KathleenDollard may have more thinking

@bricelam

This comment has been minimized.

Copy link
Member Author

commented Mar 16, 2019

Thanks, @wli3!

@ajcvickers ajcvickers removed the blocked label Mar 25, 2019

@bricelam

This comment has been minimized.

Copy link
Member Author

commented Mar 25, 2019

Hey cool, because of the code already in the CLI for source build, it looks like users will get this error when they try to run:

Cannot find command 'dotnet ef', please run the following command to install

dotnet tool install --global dotnet-ef

@divega

This comment has been minimized.

Copy link
Member

commented Apr 15, 2019

@bricelam any chance we can create an entry in the breaking change page for this today in preparation for the preview 4 announcement?

divega added a commit to aspnet/EntityFramework.Docs that referenced this issue Apr 18, 2019

divega added a commit to aspnet/EntityFramework.Docs that referenced this issue Apr 18, 2019

@divega divega modified the milestones: 3.0.0, 3.0.0-preview4 Apr 18, 2019

@derigel23

This comment has been minimized.

Copy link

commented Apr 27, 2019

Even after manually installation of dotnet-ef tool it is not available.
Got error The application to execute does not exist: 'C:\Users\Slava.Trenogin\.dotnet\tools\.store\dotnet-ef\2.2.4-servicing-10062 \dotnet-ef\2.2.4-servicing-10062\tools\netcoreapp2.2\any\dotnet-ef.dll'.
Real folder is "C:\Users\Slava.Trenogin\.dotnet\tools\.store\dotnet-ef\2.2.4\dotnet-ef\2.2.4\tools\netcoreapp2.2\any\dotnet-ef.dll"
As you can see, no -servicing-10062 suffix.

Installation was executed successfully with message:

dotnet tool install --global dotnet-ef
You can invoke the tool using the following command: dotnet-ef
Tool 'dotnet-ef' (version '2.2.4') was successfully installed.
@bricelam

This comment has been minimized.

Copy link
Member Author

commented Apr 30, 2019

Note, during pre-release, you'll need to specify the version:

dotnet tool install --global dotnet-ef --version 3.0.0-*
@khuramshahzad

This comment has been minimized.

Copy link

commented May 21, 2019

After lot of research and findings , i delete the already installed dotnet-ef (C:\Users\khurram.dotnet...) and install by using dotnet tool install --global dotnet-ef --version 3.0.0-* and it worked for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.