Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move (SELECT 1) ordering from relational to SqlServer provider #16672

Closed
roji opened this issue Jul 19, 2019 · 1 comment
Closed

Move (SELECT 1) ordering from relational to SqlServer provider #16672

roji opened this issue Jul 19, 2019 · 1 comment
Labels
closed-duplicate

Comments

@roji
Copy link
Member

roji commented Jul 19, 2019

We currently generate ORDER BY (SELECT 1) when Take is used, since SqlServer requires it. We should move that to the SqlServer provider.

We should probably test whether Sqlite is OK with not having this (like PostgreSQL).

Related: in the general case we can also elide OrderBy on constants as they're meaningless.
@ajcvickers ajcvickers added this to the Backlog milestone Jul 26, 2019
@smitpatel
Copy link
Member

Duplicate of #19332

@smitpatel smitpatel marked this as a duplicate of #19332 Jan 5, 2020
@smitpatel smitpatel removed this from the Backlog milestone Jan 5, 2020
@ajcvickers ajcvickers reopened this Oct 16, 2022
@ajcvickers ajcvickers closed this as not planned Won't fix, can't repro, duplicate, stale Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed-duplicate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ajcvickers @smitpatel @roji