Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query: Implement inheritance support for relational layer #15809

Merged
merged 1 commit into from May 29, 2019
Merged

Query: Implement inheritance support for relational layer #15809

merged 1 commit into from May 29, 2019

Conversation

smitpatel
Copy link
Member

@smitpatel smitpatel requested review from maumar and roji May 25, 2019 23:57
@smitpatel
Copy link
Member Author

@roji - This involves some breaking changes or disabled tests which has overlap with FromSql.

roji
roji reviewed May 28, 2019
View reviewed changes
Copy link
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nits for now

src/EFCore.Relational/Query/Pipeline/RelationalQueryableMethodTranslatingExpressionVisitor.cs Outdated Show resolved Hide resolved
src/EFCore.Relational/Query/Pipeline/RelationalSqlTranslatingExpressionVisitor.cs Outdated Show resolved Hide resolved
src/EFCore.Relational/Query/Pipeline/RelationalSqlTranslatingExpressionVisitor.cs Outdated Show resolved Hide resolved
src/EFCore.Relational/Query/Pipeline/RelationalSqlTranslatingExpressionVisitor.cs Outdated Show resolved Hide resolved
@smitpatel
Copy link
Member Author

@roji @maumar - Anything apart from nit? Approach looks fine?

@roji
Copy link
Member

roji commented May 29, 2019

Will try to do a more in-depth review tomorrow, but the little I saw made total sense..

@smitpatel
Copy link
Member Author

I will rebase on master then.

@smitpatel smitpatel force-pushed the smit/InHurryStance branch 2 times, most recently from 0bbe740 to 2405a18 Compare May 29, 2019 21:56
@smitpatel
Query: Implement inheritance support for relational layer
feed50c 
- Add discriminator predicate in SelectExpression (filed #15808 to remove redundant)
- Add TPH support in materializer. This happens at core level now
- Add translation for is operator inside lambda
- Add translation for OfType method
@smitpatel smitpatel merged commit 3b0795e into master May 29, 2019
@ghost ghost deleted the smit/InHurryStance branch May 29, 2019 23:56
@ajcvickers ajcvickers mentioned this pull request May 31, 2019
Closed
@smitpatel smitpatel mentioned this pull request Jun 19, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roji roji roji left review comments

@maumar maumar maumar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@smitpatel @roji @maumar