Add test verifying GroupBy with conditional aggregate #17442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There should always be regression test for scenario which failed in past. Ideally, in expression tree world, if you translate a sub-expression correctly and compose sub-expression correctly to create larger tree, everything would work. But theory fails due to developer mistakes and becomes bug. So regression test helps. |
|
Does not fix the issue #15279 (comment) Either update the PR to include regression tests for all scenarios in the issue. Or update commit message and not close the issue. |
roji
force-pushed
the
VerifyGroupByAggregateConditional
branch
from
6ecc1c6
to
e8d6e41
Compare
|
Changed commit message and moved issue back into the backlog. |
smitpatel
approved these changes
Aug 30, 2019
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15279
@smitpatel not sure there is much value but it does test conditional in aggregate and not on the key.