Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query: Throw better exception message for non-composable SQL in FromSql #18323

Merged
merged 1 commit into from
Oct 17, 2019
Merged

Query: Throw better exception message for non-composable SQL in FromSql #18323

merged 1 commit into from
Oct 17, 2019

Conversation

smitpatel
Copy link
Member

Resolves #17558

AndriySvyryd
AndriySvyryd approved these changes Oct 16, 2019
View reviewed changes
Copy link
Member

@AndriySvyryd AndriySvyryd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File an issue to throw on SQL comments inside FromSql

@smitpatel
Query: Throw better exception message for non-composable SQL in FromSql
e51292e 
Also fix issues tags
- Tags are erased when SelectExpression is recreated during visitation
- Tags are not printed for non-composed FromSql*

Resolves #17558
@smitpatel smitpatel merged commit bbf01ee into release/3.1 Oct 17, 2019
@smitpatel smitpatel deleted the smit/issue17558 branch October 17, 2019 00:35
@ajcvickers ajcvickers mentioned this pull request Oct 17, 2019
Closed
@smitpatel smitpatel mentioned this pull request Oct 20, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndriySvyryd AndriySvyryd AndriySvyryd approved these changes

@ajcvickers ajcvickers Awaiting requested review from ajcvickers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Re-introduce detection for non-composable SQL in FromSql
2 participants
@smitpatel @AndriySvyryd