Obsolete ResourceManagerWithCultureStringLocalizer and WithCulture #1133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkArtakMSFT
reviewed
Feb 19, 2019
| @@ -40,6 +41,7 @@ public interface IStringLocalizer | |||
| /// </summary> | |||
| /// <param name="culture">The <see cref="CultureInfo"/> to use.</param> | |||
| /// <returns>A culture-specific <see cref="IStringLocalizer"/>.</returns> | |||
| [Obsolete("Set the CurrentCulture and CurrentUICulture instead.")] | |||
There was a problem hiding this comment.
I think this is too strict. Let's go with: "This method is obsolete. Use CurrentCulture and CurrentUICulture instead". And please use this patter for the rest of the messages.
mkArtakMSFT
approved these changes
Feb 20, 2019
JunTaoLuo
pushed a commit
to dotnet/aspnetcore
that referenced
this pull request
Feb 12, 2020
…otnet/extensions#1133) Obsolete ResourceManagerWithCultureStringLocalizer and WithCulture \n\nCommit migrated from dotnet/extensions@924015e
JunTaoLuo
pushed a commit
to dotnet/aspnetcore
that referenced
this pull request
Feb 15, 2020
…otnet/extensions#1133) Obsolete ResourceManagerWithCultureStringLocalizer and WithCulture \n\nCommit migrated from dotnet/extensions@924015e
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/aspnetcore#3324.