Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Obsolete ResourceManagerWithCultureStringLocalizer and WithCulture #1133

Merged
merged 4 commits into from Feb 20, 2019

Conversation

@ryanbrandenburg
Copy link
Member

commented Feb 19, 2019

@ryanbrandenburg ryanbrandenburg requested a review from mkArtakMSFT Feb 19, 2019
@@ -40,6 +41,7 @@ public interface IStringLocalizer
/// </summary>
/// <param name="culture">The <see cref="CultureInfo"/> to use.</param>
/// <returns>A culture-specific <see cref="IStringLocalizer"/>.</returns>
[Obsolete("Set the CurrentCulture and CurrentUICulture instead.")]

This comment has been minimized.

Copy link
@mkArtakMSFT

mkArtakMSFT Feb 19, 2019

Member

I think this is too strict. Let's go with: "This method is obsolete. Use CurrentCulture and CurrentUICulture instead". And please use this patter for the rest of the messages.

@ryanbrandenburg ryanbrandenburg merged commit 924015e into master Feb 20, 2019
9 checks passed
9 checks passed
Extensions-ci Build #20190220.10 succeeded
Details
Extensions-ci (Code check) Code check succeeded
Details
Extensions-ci (OSX debug) OSX debug succeeded
Details
Extensions-ci (OSX release) OSX release succeeded
Details
Extensions-ci (Ubuntu 16.04 debug) Ubuntu 16.04 debug succeeded
Details
Extensions-ci (Ubuntu 16.04 release) Ubuntu 16.04 release succeeded
Details
Extensions-ci (Windows debug) Windows debug succeeded
Details
Extensions-ci (Windows release) Windows release succeeded
Details
license/cla All CLA requirements met.
Details
@ryanbrandenburg ryanbrandenburg deleted the rybrande/ObsoleteSomeLocFuncs branch Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.