Use Array.Empty<T>() #1210
Merged
Use Array.Empty<T>() #1210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use Array.Empty<string>() instead of allocating a new array if either of the strings for comparison are null.
gfoidl
reviewed
Mar 4, 2019
| @@ -41,7 +41,7 @@ public int Compare(string x, string y) | |||
| var xIsInt = x != null && int.TryParse(x, out value1); | |||
There was a problem hiding this comment.
var xIsInt = int.TryParse(x, out int value1);
var yIsInt = int.TryParse(y, out int value2);The null-check is done in TryParse, so here it is redundant. Variable initialized by the out directly.
| var xParts = x?.Split(_keyDelimiterArray, StringSplitOptions.RemoveEmptyEntries) ?? new string[0]; | ||
| var yParts = y?.Split(_keyDelimiterArray, StringSplitOptions.RemoveEmptyEntries) ?? new string[0]; | ||
| var xParts = x?.Split(_keyDelimiterArray, StringSplitOptions.RemoveEmptyEntries) ?? Array.Empty<string>(); | ||
| var yParts = y?.Split(_keyDelimiterArray, StringSplitOptions.RemoveEmptyEntries) ?? Array.Empty<string>(); | ||
|
|
||
| // Compare each part until we get two parts that are not equal | ||
| for (int i = 0; i < Math.Min(xParts.Length, yParts.Length); i++) |
There was a problem hiding this comment.
Suggested change
| for (int i = 0; i < Math.Min(xParts.Length, yParts.Length); i++) | |
| var n = Math.Min(xParts.Length, yParts.Length); | |
| for (var i = 0; i < n; i++) |
Otherwise n is evaluated at each iteration.
gfoidl
reviewed
Mar 4, 2019
| @@ -26,8 +26,8 @@ public class ConfigurationKeyComparer : IComparer<string> | |||
| /// <returns></returns> | |||
| public int Compare(string x, string y) | |||
| { | |||
| var xParts = x?.Split(_keyDelimiterArray, StringSplitOptions.RemoveEmptyEntries) ?? new string[0]; | |||
| var yParts = y?.Split(_keyDelimiterArray, StringSplitOptions.RemoveEmptyEntries) ?? new string[0]; | |||
| var xParts = x?.Split(_keyDelimiterArray, StringSplitOptions.RemoveEmptyEntries) ?? Array.Empty<string>(); | |||
There was a problem hiding this comment.
Is it a common case that either x or y is null?
If so, it may be better to hold Array.Empty<string> in a field, as the call to Empty won't be inlined (last time I checked this was true).
If not, nevermind this comment.
Tratcher
approved these changes
Mar 4, 2019
|
Thanks |
maryamariyan
pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Feb 28, 2020
Use Array.Empty<string>() instead of allocating a new array if either of the strings for comparison are null. Commit migrated from dotnet/extensions@afb772f
maryamariyan
pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 2, 2020
Use Array.Empty<string>() instead of allocating a new array if either of the strings for comparison are null. Commit migrated from dotnet/extensions@afb772f
maryamariyan
pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 11, 2020
Use Array.Empty<string>() instead of allocating a new array if either of the strings for comparison are null. Commit migrated from dotnet/extensions@afb772f
maryamariyan
pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 27, 2020
Use Array.Empty<string>() instead of allocating a new array if either of the strings for comparison are null. Commit migrated from dotnet/extensions@afb772f
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
Array.Empty<string>()instead of allocating a new array if either of the strings for comparison are null.