Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement darc dependency flow without adopting Arcade (yet) #626

Merged
merged 16 commits into from Dec 12, 2018

Conversation

natemcmaster
Copy link

This implements publishing build assets to BAR, without adopting the Arcade SDK (see #586).

Resolves #569

@natemcmaster
Copy link
Author

Internal build to verify this stuff actually works: https://dev.azure.com/dnceng/internal/_build/results?buildId=56178

@natemcmaster
Copy link
Author

@natemcmaster
Copy link
Author

/AzurePipelines run Extensions-ci

@azure-pipelines
Copy link

Success! 1 created and queued.

@natemcmaster
Copy link
Author

We're still getting some errors. @ryanbrandenburg is taking a look at this.

@ryanbrandenburg
Copy link

The problem here is that KoreBuild is overwriting the global.json when the build starts. This PR introduces an ENV to avoid this behavior.

@natemcmaster
Copy link
Author

@natemcmaster
Copy link
Author

Getting closer.

2018-12-12T03:00:31.9251470Z The property 'tools' cannot be found on this object. Verify that the property exists.
2018-12-12T03:00:31.9273638Z System.Management.Automation.PropertyNotFoundException: The property 'tools' cannot be found on this object. Verify that the property exists.
2018-12-12T03:00:31.9274457Z    at System.Management.Automation.ExceptionHandlingOps.CheckActionPreference(FunctionContext funcContext, Exception exception)
2018-12-12T03:00:31.9274686Z    at System.Management.Automation.Interpreter.ActionCallInstruction`2.Run(InterpretedFrame frame)
2018-12-12T03:00:31.9274985Z    at System.Management.Automation.Interpreter.EnterTryCatchFinallyInstruction.Run(InterpretedFrame frame)
2018-12-12T03:00:31.9275266Z    at System.Management.Automation.Interpreter.EnterTryCatchFinallyInstruction.Run(InterpretedFrame frame)

Copy link

@ryanbrandenburg ryanbrandenburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks fine to me, merge once the builds pass.

@natemcmaster
Copy link
Author

@natemcmaster natemcmaster changed the title wip: Implement darc dependency flow without adopting Arcade (yet) Implement darc dependency flow without adopting Arcade (yet) Dec 12, 2018
@natemcmaster natemcmaster merged commit 3b6488c into dotnet:master Dec 12, 2018
@natemcmaster natemcmaster deleted the dependency-flow branch December 12, 2018 23:35
natemcmaster added a commit that referenced this pull request Jan 8, 2019
Follow-up to #626 

This should complete dependency flow up Extensions from our partners.
@dotnet dotnet locked as resolved and limited conversation to collaborators May 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants